Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a manylinux_2_28 build #71

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Conversation

mayeut
Copy link
Contributor

@mayeut mayeut commented Feb 13, 2022

Per pypa/manylinux#1277 (comment) comment
Draft to check if manylinux_2_28 Proof-Of-Concept images can build openblas-libs.
This reduce testing to manylinux_2_28 at first. If all is OK, will preextend the build to check nothing broke for other builds.

cc @mattip

@mattip
Copy link
Collaborator

mattip commented Feb 14, 2022

Looks good.

@mayeut
Copy link
Contributor Author

mayeut commented Feb 19, 2022

Re-enable all builds then.

@mattip, do you know if there's an easy way to enable some testing ? Workflows seem to only do the build, no tests. Am I missing something ?

@mattip
Copy link
Collaborator

mattip commented Feb 19, 2022

We should move the linux and macOS runs off travis and onto github actions, and enable the tests.

@mayeut
Copy link
Contributor Author

mayeut commented Feb 20, 2022

We should move the linux and macOS runs off travis and onto github actions

This is already the case except for alt-arch which are running on travis-ci and that probably should remain like this (going with qemu on GHA might really prove too slow).

enable the tests

any insight on this one ?

@mattip
Copy link
Collaborator

mattip commented Jul 4, 2023

manylinux_2_17 will EOL in June 2024. We should restart this work to support manylinux_2_28 across the scientific python ecosystem. I think this as good a place as any to start

@charris
Copy link
Collaborator

charris commented Jul 4, 2023

We should restart this work to support manylinux_2_28

I was just thinking the same. We've been using manylinux2014 for a long time. It looks like 2_28 doesn't support 32 bit linux, so the two decisions are coupled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants