Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

345 rework permission #465

Merged
merged 31 commits into from
Nov 29, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
05a38f6
345 commit temp
Nov 8, 2024
ba938bf
345 commit temp
Nov 8, 2024
66decda
345 commit temp
clement-sanz Nov 12, 2024
c493f23
Merge remote-tracking branch 'remotes/origin/master' into 345_rework_…
clement-sanz Nov 15, 2024
238b7de
345 rework permissions temp commit
clement-sanz Nov 17, 2024
eb226d7
345 fix install + translation
clement-sanz Nov 18, 2024
4f90055
345 fix mysql 8 compatibility
clement-sanz Nov 19, 2024
92379dd
Merge remote-tracking branch 'remotes/origin/master' into 345_rework_…
clement-sanz Nov 19, 2024
41222ac
Merge branch 'master' into 345_rework_permission
MacWarrior Nov 21, 2024
38a96b0
Update revision
MacWarrior Nov 22, 2024
9ba6847
Merge branch 'master' into 345_rework_permission
MacWarrior Nov 23, 2024
32099ec
Update revision
MacWarrior Nov 23, 2024
1e9594c
Merge branch 'master' into 345_rework_permission
MacWarrior Nov 27, 2024
dd74c8b
Update revision
MacWarrior Nov 27, 2024
c0a0423
Update revision
MacWarrior Nov 27, 2024
c8a4e1b
345 change order operation to prevent error on permissions
clement-sanz Nov 28, 2024
2ce6095
Merge branch 'master' into 345_rework_permission
MacWarrior Nov 28, 2024
2437d3f
Update revision
MacWarrior Nov 28, 2024
9a522ae
Update revision
MacWarrior Nov 29, 2024
093560e
Merge branch 'master' into 345_rework_permission
MacWarrior Nov 29, 2024
c959274
Update revision
MacWarrior Nov 29, 2024
351d6a9
Fix PHP 8.4 compatibility, cleanup
MacWarrior Nov 29, 2024
8080c73
Merge remote-tracking branch 'remotes/origin/master' into 345_rework_…
clement-sanz Nov 29, 2024
13a022f
345 remove plugins_perms
clement-sanz Nov 29, 2024
55fd0e5
345 fix perm description translation
clement-sanz Nov 29, 2024
d4c587f
Merge branch 'master' into 345_rework_permission
MacWarrior Nov 29, 2024
40fb8ff
Fix PHP 8.4 compatibility
MacWarrior Nov 29, 2024
efbbdec
Fix playlist_access
MacWarrior Nov 29, 2024
1d92f7a
Update changelog
MacWarrior Nov 29, 2024
70388aa
Update changelog
MacWarrior Nov 29, 2024
b324174
Update changelog
MacWarrior Nov 29, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion upload/403.php
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
template_files('403.html');
} else {
$data = '403_error';
if (has_access('admin_access')) {
if ( User::getInstance()->hasAdminAccess()) {
e(lang('err_warning', ['403', 'http://docs.clip-bucket.com/?p=154']), 'w');
}
e(lang($data));
Expand Down
2 changes: 1 addition & 1 deletion upload/404.php
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
template_files('404.html');
} else {
$data = '404_error';
if (has_access('admin_access')) {
if (User::getInstance()->hasAdminAccess()) {
e(lang('err_warning', ['404', 'http://docs.clip-bucket.com/?p=154']), 'w');
}
e(lang($data));
Expand Down
7 changes: 6 additions & 1 deletion upload/actions/admin.php
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,12 @@
require_once dirname(__FILE__, 2) . '/includes/admin_config.php';

global $myquery, $cbvid, $eh;
userquery::getInstance()->admin_login_check();

if (!User::getInstance()->hasAdminAccess()) {
e(lang('insufisant_privilege'));
echo json_encode(['err'=>$eh->get_error()]);
die;
}

$mode = $_POST['mode'];
switch ($mode) {
Expand Down
2 changes: 1 addition & 1 deletion upload/actions/admin_check_timezone.php
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
define('THIS_PAGE', 'check_timezone');
require_once dirname(__FILE__, 2) . '/includes/admin_config.php';

userquery::getInstance()->admin_login_check();
User::getInstance()->hasPermissionAjax('admin_access');
$success = true;
if (empty($_POST['timezone'])) {
$success = false;
Expand Down
2 changes: 1 addition & 1 deletion upload/actions/admin_check_update.php
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
define('THIS_PAGE', 'admin_check_update');
require_once dirname(__FILE__, 2) . '/includes/admin_config.php';

userquery::getInstance()->admin_login_check();
User::getInstance()->hasPermissionAjax('admin_access');
$return = [];
if( config('enable_update_checker') == '1' ){
$return = ['status'=> Update::getInstance()->getCoreUpdateStatus(), 'html'=>Update::getInstance()->getUpdateHTML()];
Expand Down
2 changes: 1 addition & 1 deletion upload/actions/admin_comment_delete.php
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
define('THIS_PAGE', 'admin_comment_delete');
require_once dirname(__FILE__, 2) . '/includes/admin_config.php';

userquery::getInstance()->admin_login_check();
User::getInstance()->hasPermissionAjax('admin_access');

$success = true;
if (empty($_POST['comment_id'])) {
Expand Down
4 changes: 3 additions & 1 deletion upload/actions/admin_delete_social_network.php
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,9 @@
define('THIS_PAGE', 'update_phrase');
require_once dirname(__FILE__, 2) . '/includes/admin_config.php';

userquery::getInstance()->admin_login_check();
if (!User::getInstance()->hasAdminAccess()) {
return false;
}

$id_social_networks_link = $_POST['id_social_networks_link'];

Expand Down
3 changes: 1 addition & 2 deletions upload/actions/admin_import_tmdb.php
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,7 @@
define('THIS_PAGE', 'admin_import_tmdb');
require_once dirname(__FILE__, 2) . '/includes/admin_config.php';

userquery::getInstance()->admin_login_check();

User::getInstance()->hasPermissionAjax('admin_access');
Tmdb::getInstance()->importDataFromTmdb($_POST['videoid'], $_POST['tmdb_video_id'], $_POST['type']);

if (errorhandler::getInstance()->get_error() ) {
Expand Down
4 changes: 3 additions & 1 deletion upload/actions/admin_info_tmdb.php
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,9 @@
define('THIS_PAGE', 'admin_info_tmdb');
require_once dirname(__FILE__, 2) . '/includes/admin_config.php';

userquery::getInstance()->admin_login_check();
if (!User::getInstance()->hasAdminAccess()) {
return false;
}

if (config('enable_tmdb') != 'yes' || config('tmdb_token') == '') {
return false;
Expand Down
2 changes: 1 addition & 1 deletion upload/actions/admin_launch_update.php
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
define('THIS_PAGE', 'admin_launch_update');
require_once dirname(__FILE__, 2) . '/includes/admin_config.php';

userquery::getInstance()->admin_login_check();
User::getInstance()->hasPermissionAjax('admin_access');
$core_tool = new AdminTool();
$db_tool = new AdminTool();
$error_init = [];
Expand Down
2 changes: 1 addition & 1 deletion upload/actions/admin_launch_wip.php
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
define('THIS_PAGE', 'admin_import_tmdb');
require_once dirname(__FILE__, 2) . '/includes/admin_config.php';

userquery::getInstance()->admin_login_check();
User::getInstance()->hasPermissionAjax('admin_access');

$success = true;
if( Update::getInstance()->isWIPFile() ){
Expand Down
2 changes: 1 addition & 1 deletion upload/actions/admin_update_social_network.php
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
define('THIS_PAGE', 'update_phrase');
require_once dirname(__FILE__, 2) . '/includes/admin_config.php';

userquery::getInstance()->admin_login_check();
User::getInstance()->hasPermissionAjax('admin_access');

$success = true;
if (!isset($_POST['id_social_networks_link']) || !isset($_POST['title']) || !isset($_POST['url']) || !isset($_POST['social_network_link_order']) || !isset($_POST['id_fontawesome_icon'])) {
Expand Down
2 changes: 1 addition & 1 deletion upload/actions/delete_thumbs.php
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
define('THIS_PAGE', 'delete_thumbs');
require_once dirname(__FILE__, 2) . '/includes/admin_config.php';

userquery::getInstance()->admin_login_check();
User::getInstance()->hasPermissionAjax('admin_access');

# Generating more thumbs
$data = Video::getInstance()->getOne(['videoid'=>$_POST['videoid']]);
Expand Down
4 changes: 3 additions & 1 deletion upload/actions/edit_comment.php
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,9 @@
define('THIS_PAGE', 'edit_comment');
require_once dirname(__FILE__, 2) . '/includes/admin_config.php';

userquery::getInstance()->admin_login_check();
if (!User::getInstance()->hasAdminAccess()) {
return false;
}

$cid = $_POST['id'];
$value = $_POST['value'];
Expand Down
2 changes: 1 addition & 1 deletion upload/actions/file_uploader.php
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
include('../includes/config.inc.php');
require_once(dirname(__FILE__, 2) . '/includes/classes/sLog.php');

if( !has_access('allow_video_upload') ){
if( !User::getInstance()->hasPermission('allow_video_upload') ){
upload_error(lang('insufficient_privileges_loggin'));
die();
}
Expand Down
2 changes: 1 addition & 1 deletion upload/actions/force_tool_to_error.php
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
require_once dirname(__FILE__, 2) . '/includes/admin_config.php';
require_once('../includes/classes/admin_tool.class.php');

userquery::getInstance()->admin_login_check();
User::getInstance()->hasPermissionAjax('admin_access');
$tool = new AdminTool();
$tool->initById($_POST['id_tool']);
$tool->setToolError($tool->getId(), true);
Expand Down
3 changes: 1 addition & 2 deletions upload/actions/form_category.php
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,7 @@
define('THIS_PAGE', 'form_category');
require_once dirname(__FILE__, 2) . '/includes/admin_config.php';

userquery::getInstance()->admin_login_check();
pages::getInstance()->page_redir();
User::getInstance()->hasPermissionAjax('admin_access');

$type = mysql_clean($_POST['type'] ?? '');

Expand Down
2 changes: 1 addition & 1 deletion upload/actions/getVideoDetails.php
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
die();
}

if (!userquery::getInstance()->perm_check('view_video', true)) {
if (!User::getInstance()->hasPermission('view_video')) {
echo json_encode(['video' => false]);
die();
}
Expand Down
2 changes: 1 addition & 1 deletion upload/actions/language_add.php
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
define('THIS_PAGE', 'language_add');
require_once dirname(__FILE__, 2) . '/includes/admin_config.php';

userquery::getInstance()->admin_login_check();
User::getInstance()->hasPermissionAjax('admin_access');

Language::add_lang($_POST);

Expand Down
2 changes: 1 addition & 1 deletion upload/actions/language_delete.php
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
define('THIS_PAGE', 'language_delete');
require_once dirname(__FILE__, 2) . '/includes/admin_config.php';

userquery::getInstance()->admin_login_check();
User::getInstance()->hasPermissionAjax('admin_access');

Language::delete_lang($_POST['language_id']);
display_language_list();
2 changes: 1 addition & 1 deletion upload/actions/language_make_default.php
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
define('THIS_PAGE', 'language_make_default');
require_once dirname(__FILE__, 2) . '/includes/admin_config.php';

userquery::getInstance()->admin_login_check();
User::getInstance()->hasPermissionAjax('admin_access');

if (!empty($_POST['make_default'])) {
Language::getInstance()->make_default($_POST['make_default']);
Expand Down
2 changes: 1 addition & 1 deletion upload/actions/language_restorable_list.php
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,6 @@
define('THIS_PAGE', 'language_restorable_list');
require_once dirname(__FILE__, 2) . '/includes/admin_config.php';

userquery::getInstance()->admin_login_check();
User::getInstance()->hasPermissionAjax('admin_access');

display_restorable_language_list();
2 changes: 1 addition & 1 deletion upload/actions/language_restore.php
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
define('THIS_PAGE', 'language_restore');
require_once dirname(__FILE__, 2) . '/includes/admin_config.php';

userquery::getInstance()->admin_login_check();
User::getInstance()->hasPermissionAjax('admin_access');

Language::restore_lang($_POST['code']);

Expand Down
2 changes: 1 addition & 1 deletion upload/actions/language_update.php
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<?php
require_once dirname(__FILE__, 2) . '/includes/admin_config.php';

userquery::getInstance()->admin_login_check();
User::getInstance()->hasPermissionAjax('admin_access');

Language::update_lang($_POST);

Expand Down
2 changes: 1 addition & 1 deletion upload/actions/launch_tool.php
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@

$tool->setToolInProgress();
} else {
userquery::getInstance()->admin_login_check();
User::getInstance()->hasPermissionAjax('admin_access');

if($tool->initById($_POST['id_tool']) === false) {
e(lang('tool_not_found'));
Expand Down
2 changes: 1 addition & 1 deletion upload/actions/photo_uploader.php
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
define('THIS_PAGE', 'photo_uploader');
include('../includes/config.inc.php');

if( !has_access('allow_photo_upload') ){
if( !User::getInstance()->hasPermission('allow_photo_upload') ){
upload_error(lang('insufficient_privileges_loggin'));
die();
}
Expand Down
2 changes: 1 addition & 1 deletion upload/actions/regenerate_thumbs.php
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
define('THIS_PAGE', 'regenerate_thumbs');
require_once dirname(__FILE__, 2) . '/includes/admin_config.php';

userquery::getInstance()->admin_login_check();
User::getInstance()->hasPermissionAjax('admin_access');

# Generating more thumbs
$data = get_video_details($_POST['videoid']);
Expand Down
2 changes: 1 addition & 1 deletion upload/actions/resolution_delete.php
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
define('THIS_PAGE', 'resolution_delete');
require_once dirname(__FILE__, 2) . '/includes/admin_config.php';

userquery::getInstance()->admin_login_check();
User::getInstance()->hasPermissionAjax('admin_access');

$resolution = $_POST['resolution'];

Expand Down
3 changes: 2 additions & 1 deletion upload/actions/show_tool_log.php
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,8 @@
define('THIS_PAGE', 'show_tool_log');
require_once dirname(__FILE__, 2) . '/includes/admin_config.php';

userquery::getInstance()->admin_login_check();
User::getInstance()->hasPermissionAjax('admin_access');

$tool = new AdminTool();
$tool->initById($_POST['id_tool']);

Expand Down
2 changes: 1 addition & 1 deletion upload/actions/stop_tool.php
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
require_once dirname(__FILE__, 2) . '/includes/admin_config.php';
require_once('../includes/classes/admin_tool.class.php');

userquery::getInstance()->admin_login_check();
User::getInstance()->hasPermissionAjax('admin_access');
$tool = new AdminTool();
$tool->initById($_POST['id_tool']);
$tool->stop();
Expand Down
2 changes: 1 addition & 1 deletion upload/actions/subtitle_delete.php
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
define('THIS_PAGE', 'subtitle_delete');
require_once dirname(__FILE__, 2) . '/includes/admin_config.php';

userquery::getInstance()->admin_login_check();
User::getInstance()->hasPermissionAjax('admin_access');

$video = $_POST['videoid'];
$number = $_POST['number'];
Expand Down
2 changes: 1 addition & 1 deletion upload/actions/subtitle_edit.php
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
define('THIS_PAGE', 'subtitle_edit');
require_once dirname(__FILE__, 2) . '/includes/admin_config.php';

userquery::getInstance()->admin_login_check();
User::getInstance()->hasPermissionAjax('admin_access');

$video = $_POST['videoid'];
$number = $_POST['number'];
Expand Down
2 changes: 1 addition & 1 deletion upload/actions/tag_delete.php
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
define('THIS_PAGE', 'tag_delete');
require_once dirname(__FILE__, 2) . '/includes/admin_config.php';

userquery::getInstance()->admin_login_check();
User::getInstance()->hasPermissionAjax('admin_access');

$id_tag = $_POST['id_tag'];

Expand Down
2 changes: 1 addition & 1 deletion upload/actions/tag_update.php
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
define('THIS_PAGE', 'tag_update');
require_once dirname(__FILE__, 2) . '/includes/admin_config.php';

userquery::getInstance()->admin_login_check();
User::getInstance()->hasPermissionAjax('admin_access');

$id_tag = $_POST['id_tag'];
$tag = $_POST['tag'];
Expand Down
2 changes: 1 addition & 1 deletion upload/actions/test_tmdb.php
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
define('THIS_PAGE', 'test_tmdb');
require_once dirname(__FILE__, 2) . '/includes/admin_config.php';

userquery::getInstance()->admin_login_check();
User::getInstance()->hasPermissionAjax('admin_access');

try {
$tmdb = new TMdb();
Expand Down
2 changes: 1 addition & 1 deletion upload/actions/update_frequency_disabled_tool.php
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@

try {
$tool = new AdminTool();
userquery::getInstance()->admin_login_check();
User::getInstance()->hasPermissionAjax('admin_access');
if($tool->initById($_POST['id_tool']) === false) {
throw new Exception('tool not found');
}
Expand Down
2 changes: 1 addition & 1 deletion upload/actions/update_frequency_tool.php
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

try {
$tool = new AdminTool();
userquery::getInstance()->admin_login_check();
User::getInstance()->hasPermissionAjax('admin_access');
if($tool->initById($_POST['id_tool']) === false) {
throw new Exception('tool not found');
}
Expand Down
2 changes: 1 addition & 1 deletion upload/actions/update_phrase.php
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
define('THIS_PAGE', 'update_phrase');
require_once dirname(__FILE__, 2) . '/includes/admin_config.php';

userquery::getInstance()->admin_login_check();
User::getInstance()->hasPermissionAjax('admin_access');

$id_language_key = $_POST['id_language_key'];
$translation = $_POST['translation'];
Expand Down
2 changes: 1 addition & 1 deletion upload/actions/upgrade_db.php
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@
}

} else {
userquery::getInstance()->admin_login_check();
User::getInstance()->hasPermissionAjax('admin_access');
if (empty($_REQUEST['version']) || empty($_REQUEST['revision'])) {
error_lang_cli('Version or revision is missing');
$error = true;
Expand Down
2 changes: 1 addition & 1 deletion upload/admin_area/action_logs.php
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

require_once dirname(__FILE__, 2) . '/includes/admin_config.php';

userquery::getInstance()->admin_login_check();
User::getInstance()->hasPermissionOrRedirect('admin_access', true);
pages::getInstance()->page_redir();

/* Generating breadcrumb */
Expand Down
3 changes: 1 addition & 2 deletions upload/admin_area/add_member.php
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,7 @@

require_once dirname(__FILE__, 2) . '/includes/admin_config.php';

userquery::getInstance()->admin_login_check();
userquery::getInstance()->login_check('member_moderation');
User::getInstance()->hasPermissionOrRedirect('member_moderation', true);
pages::getInstance()->page_redir();

/* Generating breadcrumb */
Expand Down
3 changes: 1 addition & 2 deletions upload/admin_area/admin_tool.php
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,7 @@

require_once dirname(__FILE__, 2) . '/includes/admin_config.php';

userquery::getInstance()->admin_login_check();
userquery::getInstance()->login_check('web_config_access');
User::getInstance()->hasPermissionOrRedirect('web_config_access',true);
pages::getInstance()->page_redir();

/* Generating breadcrumb */
Expand Down
Loading