Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sprite #4

Draft
wants to merge 32 commits into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
82f8b65
feat: add a sprite
aquino-luane Oct 15, 2024
902eba6
feat: setup assets store + consume sprites and keep in store
aquino-luane Oct 23, 2024
0699607
feat: setup store for costumes + consume data from api
aquino-luane Oct 23, 2024
ccc0813
feat: update urls with real endpoints
aquino-luane Jan 21, 2025
3b15474
resolve merge conflicts with main
aquino-luane Jan 21, 2025
31913de
feat: update url to get a sprite by id
aquino-luane Jan 21, 2025
b81720f
feat: update url to get a assets by id
aquino-luane Jan 21, 2025
55b427d
refactor: remove changes to package.json
aquino-luane Jan 21, 2025
c9683e4
resolve merge conflicts with poc/user-session-v2
aquino-luane Jan 22, 2025
6e2e758
refactor: remove duplicated import
aquino-luane Jan 22, 2025
7339f3c
feat: retry when toke is expired when getting sprites and costumes
aquino-luane Jan 23, 2025
9bc54c2
feat: update url to https
aquino-luane Jan 24, 2025
c02f01b
feat: redirect to login page if retry fails
aquino-luane Jan 27, 2025
376dcc2
feat: create function getToken
aquino-luane Jan 28, 2025
e10411f
fix: move request to get token to another file
aquino-luane Jan 28, 2025
05efa7a
refactor: remove mock url
aquino-luane Jan 28, 2025
84d42d8
feat: add code to show sounds
aquino-luane Jan 29, 2025
5ae1ab0
fix: update url of get assets
aquino-luane Feb 5, 2025
264f495
merge with feature/save-project
aquino-luane Feb 5, 2025
ddaa6a6
fix: remove duplicates + add code to mock url
aquino-luane Feb 5, 2025
5c089e4
Merge branch 'main' into poc/add-sprite
aquino-luane Feb 5, 2025
0fcc389
Merge branch 'main' into poc/add-sprite
aquino-luane Feb 6, 2025
f07e463
Merge branch 'bugfix/remove-user-from-token' into poc/add-sprite
aquino-luane Feb 6, 2025
e726ea1
refactor(hash-parser-hoc): add FIXME
aquino-luane Feb 10, 2025
6184337
Merge branch 'main' into poc/add-sprite
aquino-luane Feb 14, 2025
991c4a4
fix: remove file format to fix display of sprites library
aquino-luane Feb 21, 2025
f3efab5
merge poc/add-sprite into feature/add-sounds
aquino-luane Feb 21, 2025
6fc6b9c
fix: adjust sounds url
aquino-luane Feb 21, 2025
38eb0af
feat: show projects list button
aquino-luane Feb 21, 2025
0186b43
fix: adjust error screen text
aquino-luane Feb 21, 2025
a908954
fix: remove audio format
aquino-luane Feb 25, 2025
b29a4d1
Merge pull request #13 from MacareuxDigital/feature/add-sounds
hissy Feb 25, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/containers/library-item.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ class LibraryItem extends React.PureComponent {
render () {
const iconMd5 = this.curIconMd5();
const iconURL = iconMd5 ?
`https://cdn.assets.scratch.mit.edu/internalapi/asset/${iconMd5}/get/` :
`http://localhost:3000/image/${iconMd5}` :
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@biplobice @hissy
Is there an API endpoint that I can get an individual sprite by passing its MD5 value?

It seems that this is needed, because if I don't nothing shows in this screen (first image). Although if I select any sprite like "Andie" it will show in the editor (second image)...
Image 1:
image
Image 2:
image

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aquino-luane
Cc: @SashaMcr
Yes, there is. The /md/api/assets is for that purpose.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

this.props.iconRawURL;
return (
<LibraryItemComponent
Expand Down
Loading