This repository was archived by the owner on Mar 3, 2022. It is now read-only.
Reorganize contracts in the src folder #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope
This PR is reorganizing all the contracts inside the folder src for better clarity.
The only file removed in the PR was src/Experiment.t.sol, the rest of the files were just moved around. The imports in all the contracts were fixed to reflect the new locations. The commands
make allandmake testwere executed successfully without any change in the number of files compiled of tests executed.The new folder struct:
Why?
The contracts were moved in order to have a separation of concerns.
Todos
The following PRs will be removing the git submodules in order to make the contracts compatible with any smart contract frameworks (truffle, hardhat, remix, etc).