This repository has been archived by the owner on Oct 19, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 157
Lack of typing #181
Comments
@antoine-pous I agree, 1 would be the best approach. Keeping separate types up-to-date is a pain. |
@antoine-pous did you ever get to try to migrate? |
@vkhomiv-hubspot what's your take on this? We've had half-a-dozen issues related to typing. They're always annoying to maintain when generated on the side. My inclination (since I do mostly typescript these days) would be to migrate the full library to typescript, but wondering what you think? |
@pcothenet i've created a typescript branch, actually i don't really made changes, just migrate the codebase to TS step by step |
I agree it's a big deal. |
@antoine-pous any update on this? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Actually this lib do a great job but the lack of typing for most of
opts
parameters is really painful.We have to check regularly HubSpot APIs doc to know which fields/values are accepted.
I would like help to improve this part but i don't really know which way will be better, so i would like having some advices:
I think the one is the best thing to do before this module become too big, actually moving to TypeScript shouldn't be so long and can ensure the code quality.
The text was updated successfully, but these errors were encountered: