Skip to content
This repository has been archived by the owner on Oct 19, 2023. It is now read-only.

Lack of typing #181

Open
antoine-pous opened this issue Jul 30, 2019 · 6 comments
Open

Lack of typing #181

antoine-pous opened this issue Jul 30, 2019 · 6 comments

Comments

@antoine-pous
Copy link
Contributor

Actually this lib do a great job but the lack of typing for most of opts parameters is really painful.

We have to check regularly HubSpot APIs doc to know which fields/values are accepted.

I would like help to improve this part but i don't really know which way will be better, so i would like having some advices:

  1. Full refactor to move the whole codebase to TypeScript, following the latests standards
  2. Improve the current types file which can become really painful instead of maintaining the TypeScript codebase

I think the one is the best thing to do before this module become too big, actually moving to TypeScript shouldn't be so long and can ensure the code quality.

@pcothenet
Copy link
Contributor

pcothenet commented Aug 28, 2019

@antoine-pous I agree, 1 would be the best approach. Keeping separate types up-to-date is a pain.

@pcothenet
Copy link
Contributor

@antoine-pous did you ever get to try to migrate?

@pcothenet
Copy link
Contributor

@vkhomiv-hubspot what's your take on this? We've had half-a-dozen issues related to typing. They're always annoying to maintain when generated on the side. My inclination (since I do mostly typescript these days) would be to migrate the full library to typescript, but wondering what you think?

@antoine-pous
Copy link
Contributor Author

@pcothenet i've created a typescript branch, actually i don't really made changes, just migrate the codebase to TS step by step

@vkhomiv-hubspot
Copy link
Collaborator

I agree it's a big deal.

@phips28
Copy link

phips28 commented Jan 22, 2020

@antoine-pous any update on this?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants