This repository has been archived by the owner on Oct 19, 2023. It is now read-only.
Implement owners.betById #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why:
Note:
RemoteTypeandOwnerTypeare not really explained in the API doculmentation, then i don't really know which presets exists. If you've them i can easily improve types.I've moved from nock to HS demo API for one reason, for a project like this one, which wrap an API which is maintained by other devs you can't trust at 100% your work. To avoid mistypings due to undocumented changes the best way is dealing with the API. The test duration is not a big issue and adding a daily test job let you know when the package is no anymore compliant with the current API version.
Maybe am i wrong, but i don't think.
Related issues: #181 and #182