Standardisation changes #48
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also makes it more stable for an initial install Also stops replacing the `UploadField` with a custom one This means that default SS behaviour is not messed with
…d that will be used for padding
…so no need to prevent it via admin
… = false` for compatibility with parent
…o another Was just missing a `clone` (doh!)
Adds `::getCMSFields()` as well as `summary_fields` & `searchable_fields`
Also have the UploadImageField default to only allowing the `image` category
Should be much simpler than original implementation
… for getting the filesize Also added `CloudinaryStorage::getMetadata()` call and adds Hash/Variant data as it allows lookup
I'll be adding this back in with extra "Meta data" from Cloudinary including derived images Also fixes issue as Cloudinary sees pdf's as images :/
…linked file exists as well
… for the field itself Added some styling so as to remove the space to the left if no label has been set
oilee80
force-pushed
the
standardization-changes
branch
from
15eb33a to
dc325d9
Compare
Still need to fix issue where its not saving a value :/
… with Gravity on the fallback Image object
Getting errors if the file is not local Also adds a check for `version` as its not always part of the `resource` response (e.g. thirdpary URL)
Otherwise I get a `BadRequest` response
… change where as `PublicID` does Heres hoping
Also refactored what was already there
Add descriptions to Gravities
…rocessing the names
…ation If filetype is not supported by SS, continue to next file instead of …
…racters in publicID Cloudinary doesnt differentiate between accented and non-accented and was causing an error See https://stackoverflow.com/questions/27680624/compare-two-string-and-ignore-but-not-replace-accents-php\#answer-67381756 for reference code Updated `cloudinary_php` to V2 Adds a check to see if `access_mode` key is set before checking if `public` Adds option to check if File exists in cloudinary (uses HEAD request) Wraps `file-exists-check` header in if so that only displays in DEV mode If 404 response when attempting rename then delete the file locally
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.