Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR :: 에러 로그, 응답 관련 리팩토링 #216

Merged
merged 7 commits into from
May 9, 2024

Conversation

Daybreak312
Copy link
Member

어떤 종류의 PR 인가요?

/kind 리펙토링

이 PR이 무슨 일을 하나요? / 필요한 이유가 뭔가요?

  • 에러 로그와 에러 응답에서 보여지는 message를 분리했습니다.
  • 에러 로그의 포맷을 다시 작성했습니다.
  • 에러 로그 출력을 클래스로 분리했습니다.
  • Exception이 처리되는 구조를 일부 수정했습니다.

리뷰어를 위한 참고사항:


@Daybreak312 Daybreak312 requested a review from HyunSu1768 as a code owner May 9, 2024 10:59
@Daybreak312 Daybreak312 self-assigned this May 9, 2024
@maeumgagym-ci-robot-app
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Daybreak312

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Member

@gurdl0525 gurdl0525 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@maeumgagym-ci-robot-app maeumgagym-ci-robot-app bot added the lgtm Looks good to me label May 9, 2024
@maeumgagym-ci-robot-app maeumgagym-ci-robot-app bot merged commit 082348e into develop May 9, 2024
3 checks passed
@maeumgagym-ci-robot-app maeumgagym-ci-robot-app bot deleted the Exception-refactor branch May 9, 2024 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants