Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework UI #110

Merged
merged 5 commits into from
Dec 28, 2024
Merged

Rework UI #110

merged 5 commits into from
Dec 28, 2024

Conversation

Deewarz
Copy link
Contributor

@Deewarz Deewarz commented Mar 15, 2024 •
edited
Loading

Global

  • Add a way to disable processing of mouse and keyboard events
  • Add UIBase: base class for all UI to manage visibility, blocked controls, custom window (specific design when controls are locked)...

Console

  • Virtual extends from UIBase
  • Use custom window from UIBase (remove console-level window design when controls are locked in favor of global behavior)
  • Remove Multiline (not compatible with history: https://github.com/ocornut/imgui/blob/master/imgui_widgets.cpp#L4093)
  • Remove the control lock toggle in favor of global integration at project level
  • Improve design when controls unlocked (no scrollbar, no ghost spacing, padding fixes, ...)
  • Cleanup code (useless condition, variable names, indentation, ...)

@Deewarz Deewarz self-assigned this Mar 15, 2024
@Deewarz Deewarz mentioned this pull request Mar 15, 2024
Merged
@Deewarz Deewarz marked this pull request as ready for review March 15, 2024 17:47
@Deewarz Deewarz requested review from zpl-zak and Segfaultd March 15, 2024 17:47
@Segfaultd Segfaultd merged commit 42374d7 into develop Dec 28, 2024
2 of 4 checks passed
@Segfaultd Segfaultd deleted the rework-ui branch December 28, 2024 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zpl-zak zpl-zak Awaiting requested review from zpl-zak

@Segfaultd Segfaultd Awaiting requested review from Segfaultd

Assignees

@Deewarz Deewarz

Labels
None yet
Projects
MafiaHub Dashboard
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Deewarz @Segfaultd