This repository has been archived by the owner on Jul 11, 2024. It is now read-only.
Correct regex for bindshell port detection, update ss parameter to reveal ports #12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue is located in bindshell part. Specifically,
Checking 'bindshell'... INFECTED PORTS: ( 145)
.The regex should be
":${P}[^0-9.:]"
as the function is only aiming at ports, instead of[.:]
in the beginning part.As CMD=
loc ss ss $pth
failed [1], the script is usingss -a
[2] to do the ports revealing. Thus the output contains strange string.ss -an
change brings in correct numbered ports for detection. Along with the regex to prevent false positives.Please let me know your thoughts, thanks.
[1]https://github.com/Magentron/chkrootkit/blob/master/chkrootkit#L2892
[2]https://man7.org/linux/man-pages/man8/ss.8.html