Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restricting imageio to 0.5+ #4401

Merged
merged 1 commit into from
Sep 24, 2024
Merged

Restricting imageio to 0.5+ #4401

merged 1 commit into from
Sep 24, 2024

Conversation

SimonDanisch
Copy link
Member

Closes #3461

@SimonDanisch SimonDanisch added the skip-changelog Skips changelog enforcer label Sep 24, 2024
@MakieBot
Copy link
Collaborator

MakieBot commented Sep 24, 2024

Compile Times benchmark

Note, that these numbers may fluctuate on the CI servers, so take them with a grain of salt. All benchmark results are based on the mean time and negative percent mean faster than the base branch. Note, that GLMakie + WGLMakie run on an emulated GPU, so the runtime benchmark is much slower. Results are from running:

using_time = @ctime using Backend
# Compile time
create_time = @ctime fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @ctime Makie.colorbuffer(display(fig))
# Runtime
create_time = @benchmark fig = scatter(1:4; color=1:4, colormap=:turbo, markersize=20, visible=true)
display_time = @benchmark Makie.colorbuffer(fig)
using create display create display
GLMakie 4.48s (4.42, 4.59) 0.07+- 108.84ms (104.64, 119.27) 5.01+- 476.56ms (460.74, 491.72) 11.06+- 9.51ms (9.38, 9.63) 0.09+- 26.04ms (25.86, 26.41) 0.21+-
master 4.49s (4.44, 4.56) 0.04+- 107.76ms (104.65, 111.53) 2.35+- 447.43ms (411.52, 473.64) 28.61+- 9.26ms (9.01, 9.44) 0.17+- 26.11ms (25.93, 26.54) 0.20+-
evaluation 1.00x invariant, -0.01s (-0.26d, 0.63p, 0.06std) 0.99x invariant, 1.07ms (0.27d, 0.62p, 3.68std) 0.94x slower❌, 29.13ms (1.34d, 0.04p, 19.84std) 0.97x slower X, 0.25ms (1.81d, 0.01p, 0.13std) 1.00x invariant, -0.07ms (-0.34d, 0.54p, 0.21std)
CairoMakie 4.19s (4.13, 4.22) 0.03+- 107.87ms (107.10, 109.32) 0.86+- 169.15ms (167.44, 171.49) 1.53+- 9.45ms (9.18, 9.67) 0.19+- 1.17ms (1.14, 1.21) 0.03+-
master 4.19s (4.14, 4.26) 0.04+- 109.85ms (105.36, 123.41) 6.10+- 170.43ms (166.64, 183.80) 6.13+- 9.65ms (9.55, 9.77) 0.09+- 1.15ms (1.14, 1.15) 0.00+-
evaluation 1.00x invariant, -0.0s (-0.06d, 0.91p, 0.04std) 1.02x invariant, -1.98ms (-0.45d, 0.43p, 3.48std) 1.01x invariant, -1.27ms (-0.29d, 0.61p, 3.83std) 1.02x faster ✓, -0.2ms (-1.30d, 0.04p, 0.14std) 0.98x invariant, 0.03ms (1.17d, 0.07p, 0.02std)
WGLMakie 4.77s (4.73, 4.93) 0.07+- 109.31ms (106.99, 113.86) 2.27+- 9.23s (9.01, 9.79) 0.26+- 11.95ms (11.40, 13.44) 0.80+- 117.49ms (113.46, 121.26) 3.24+-
master 4.78s (4.71, 4.95) 0.09+- 109.96ms (106.06, 115.86) 3.03+- 9.55s (9.40, 9.83) 0.15+- 11.67ms (11.38, 11.87) 0.19+- 117.08ms (113.91, 121.43) 2.66+-
evaluation 1.00x invariant, -0.01s (-0.13d, 0.81p, 0.08std) 1.01x invariant, -0.66ms (-0.24d, 0.66p, 2.65std) 1.03x faster ✓, -0.32s (-1.52d, 0.02p, 0.20std) 0.98x invariant, 0.28ms (0.48d, 0.40p, 0.50std) 1.00x invariant, 0.41ms (0.14d, 0.80p, 2.95std)

@SimonDanisch SimonDanisch merged commit bb5cc0a into master Sep 24, 2024
18 of 19 checks passed
@SimonDanisch SimonDanisch deleted the sd/stricter-imageio branch September 24, 2024 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog Skips changelog enforcer
Projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

Precompiling GLMakie fails with ImageIO 0.4
2 participants