Get rid of TuxFamily #119
Open
Get rid of TuxFamily #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DeeJayLSP
commented
Feb 22, 2025
| @@ -114,8 +96,8 @@ func install_zip(zip_abs_path, root_unzip_folder_name, possible_editor_name, on_ | |||
| var editor_install = _editor_install_scene.instantiate() | |||
| add_child(editor_install) | |||
| editor_install.init(possible_editor_name, zip_content_dir) | |||
| editor_install.installed.connect(func(name, exec_path): | |||
| installed.emit(name, ProjectSettings.globalize_path(exec_path)) | |||
| editor_install.installed.connect(func(p_name, exec_path): | |||
There was a problem hiding this comment.
name is a reserved variable from Node, therefore I changed it to avoid conflicts.
DeeJayLSP
force-pushed
the
no-tuxfamily
branch
from
4b657df to
562e9f8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TuxFamily has been offline for so long that the Godot maintainers themselves stopped supporting it officially.
This PR removes the mirror dropdown in favor of GitHub releases only.
Closes #116