Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade cypress to allow Firefox tests to proceed. #9380

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Fryguy
Copy link
Member

@Fryguy Fryguy commented Mar 24, 2025

A change in a newer Firefox version prevents cypress from running, but
that was fixed in a newer cypress. This commit upgrades to that version
as a minimum.

@elsamaryv Please review. cc @GilbertCherrie

Note that the cypress tests still fail after this, but at least they proceed. Here's an example run: https://github.com/Fryguy/manageiq-ui-classic/actions/runs/14046664292/job/39328843180

@Fryguy Fryguy requested a review from a team as a code owner March 24, 2025 21:49
@Fryguy Fryguy changed the title [WIP] Upgrade cypress Upgrade cypress Mar 25, 2025
@Fryguy Fryguy changed the title Upgrade cypress Upgrade cypress to allow Firefox tests to proceed. Mar 25, 2025
@Fryguy Fryguy changed the title Upgrade cypress to allow Firefox tests to proceed. [WIP] Upgrade cypress to allow Firefox tests to proceed. Mar 25, 2025
@Fryguy
Copy link
Member Author

Fryguy commented Mar 25, 2025

Marking as WIP as I want to dedupe the dependencies first, but it's overlapping with other dedupes. I opened #9381 first to get those out of the way.

A change in a newer Firefox version prevents cypress from running, but
that was fixed in a newer cypress. This commit upgrades to that version
as a minimum.
@Fryguy Fryguy changed the title [WIP] Upgrade cypress to allow Firefox tests to proceed. Upgrade cypress to allow Firefox tests to proceed. Mar 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants