-
Notifications
You must be signed in to change notification settings - Fork 900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Drop broadcast logger #22798
base: master
Are you sure you want to change the base?
[WIP] Drop broadcast logger #22798
Conversation
872369b
to
811ea67
Compare
Checked commits agrare/manageiq@e722858~...515eefe with ruby 2.7.8, rubocop 1.56.3, haml-lint 0.51.0, and yamllint spec/lib/vmdb/loggers_spec.rb
|
This pull request is not mergeable. Please rebase and repush. |
This pull request has been automatically marked as stale because it has not been updated for at least 3 months. If these changes are still valid, please remove the |
1 similar comment
This pull request has been automatically marked as stale because it has not been updated for at least 3 months. If these changes are still valid, please remove the |
When we were logging to both files and stdout / journald we needed every logger to be a broadcast logger, now that that is no longer the case we can return the "raw" logger.
This also will make it simpler for us to be able to create "ad-hoc" loggers with additional metadata like a logger for a specific MiqRequest with the request_id as a tag.
TODO