Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Drop broadcast logger #22798

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

agrare
Copy link
Member

@agrare agrare commented Nov 28, 2023

When we were logging to both files and stdout / journald we needed every logger to be a broadcast logger, now that that is no longer the case we can return the "raw" logger.

This also will make it simpler for us to be able to create "ad-hoc" loggers with additional metadata like a logger for a specific MiqRequest with the request_id as a tag.

TODO

  • Get tests passing with the raw logger
  • What to do with the StringIO type?
  • Convert the vmdb/loggers/ classes to modules to extend the journal/container loggers

@agrare agrare requested a review from Fryguy as a code owner November 28, 2023 19:19
@miq-bot miq-bot added the wip label Nov 28, 2023
@agrare agrare added the core label Nov 28, 2023
@miq-bot
Copy link
Member

miq-bot commented Nov 28, 2023

Checked commits agrare/manageiq@e722858~...515eefe with ruby 2.7.8, rubocop 1.56.3, haml-lint 0.51.0, and yamllint
2 files checked, 2 offenses detected

spec/lib/vmdb/loggers_spec.rb

@ManageIQ ManageIQ deleted a comment from kbrock Jan 4, 2024
@miq-bot
Copy link
Member

miq-bot commented Mar 11, 2024

This pull request is not mergeable. Please rebase and repush.

@miq-bot
Copy link
Member

miq-bot commented Jun 17, 2024

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s).

1 similar comment
@miq-bot
Copy link
Member

miq-bot commented Sep 23, 2024

This pull request has been automatically marked as stale because it has not been updated for at least 3 months.

If these changes are still valid, please remove the stale label, make any changes requested by reviewers (if any), and ensure that this issue is being looked at by the assigned/reviewer(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants