ReadOnly models respond false to supports?(:update)

[kbrock]

Extracted from #23140

Goal

When asking a read only model Model#supports?(:delete) (or update) it will correctly respond no.

Yes, we did have 2 false positives adding read_only behavior to models that used that column for another meaning. But these were resolved a long time ago.

Previous PRs that addressed ReadOnly concerns

• Add validations to prevent delete on read only models #22232
• Don't reject AdvancedSetting#destroy if read-only #22857
• allow dialogs to be destroyed with read only dialog fields #22493

[miq-bot]

Checked commit kbrock@d210d9a with ruby 3.1.5, rubocop 1.56.3, haml-lint 0.51.0, and yamllint
1 file checked, 0 offenses detected
Everything looks fine. 🍰

[Fryguy]

I'm confused - read_only doesn't mean that we can't do things on a provider - it just means we can't change things in the database record itself. Can you give a specific model example of where this applies?

[kbrock]

ok, so maybe this was an old branch with a dumb idea.

We have ReadOnly for the following models:

• miq_widget
• miq_user_role
• miq_policy
• miq_policy_set
• condition
• classification
• miq_alert

I thought we used that to show whether an action was supported in the ui.
So if the miq_widget.supports?(:update) == false if miq_widget.read_only?

[kbrock]

just cleaning things up. not worth it right now

[Fryguy]

I thought we used that to show whether an action was supported in the ui.

Yeah you might be right? I think there was some conflating of "provider supports" type things and "miq supports" type things and that's why we're in this state.