[WIP] Fix warnings raised by URI 1.0.1 #23261

jrafanie · 2024-11-08T17:51:51Z

WIP:

cross repo
This PR and the related PRs require bumping URI to 1.0.1+. Determine when it's a good time to do this.
When ready, merge related PRs after this one:

Related to:
https://www.github.com/ruby/uri/issues/125
#23260

jrafanie · 2024-11-08T18:40:43Z

@miq-bot cross-repo-tests /all, ManageIQ/manageiq-providers-ovirt#680 ManageIQ/manageiq-providers-vmware#926 ManageIQ/manageiq-gems-pending#596 ManageIQ/manageiq-ui-classic#9307 ManageIQ/vmware_web_service#141 ManageIQ/manageiq-automation_engine#562

From Pull Request: ManageIQ/manageiq#23261

jrafanie · 2024-11-08T22:51:20Z

ok, cross repo: ManageIQ/manageiq-cross_repo-tests#928 is green other than an issue requiring qpid_proton in nuage and openstack:

    1) OpenstackStfEventMonitor connecting to STF service URL prepare QDR endpoint
       Failure/Error: require 'qpid_proton'
  
       ArgumentError:
         wrong number of arguments (given 1, expected 0)
       # ./spec/legacy/events/openstack_stf_event_monitor_spec.rb:5:in `block (2 levels) in <top (required)>'

...

https://github.com/ManageIQ/manageiq-cross_repo-tests/actions/runs/11749197033/job/32736846677?pr=928

    1) ManageIQ::Providers::Nuage::NetworkManager::EventCatcher::Runner .event_monitor_handle
       Failure/Error: require 'qpid_proton'
  
       ArgumentError:
         wrong number of arguments (given 1, expected 0)
       # ./app/models/manageiq/providers/nuage/network_manager/event_catcher/stream.rb:25:in `initialize'
       # ./app/models/manageiq/providers/nuage/network_manager/event_catcher/runner.rb:7:in `new'
       # ./app/models/manageiq/providers/nuage/network_manager/event_catcher/runner.rb:7:in `event_monitor_handle'
       # ./spec/models/manageiq/providers/nuage/network_manager/event_catcher/runner_spec.rb:12:in `block (2 levels) in <top (required)>'

https://github.com/ManageIQ/manageiq-cross_repo-tests/actions/runs/11749197033/job/32736846113?pr=928

@agrare Have you seen this before?

kbrock · 2024-11-11T16:19:03Z

Looks like legit issues with nuage, openstack: number of args to constructor

jrafanie · 2024-11-11T16:27:38Z

Looks like legit issues with nuage, openstack: number of args to constructor

yeah, thanks, I was meaning to look at those again today

jrafanie · 2024-11-11T16:46:37Z

Looks like legit issues with nuage, openstack: number of args to constructor

I wonder if the warnings about uri 1.0.1 are an indicator it's related to 1.0.1

  /home/runner/work/manageiq-cross_repo-tests/manageiq-cross_repo-tests/repos/ManageIQ/manageiq-providers-nuage@3c618859dc3655db13b3a59ae6ab1a41d237162b/vendor/bundle/ruby/3.0.0/gems/qpid_proton-0.37.0/lib/core/uri.rb:32: warning: already initialized constant URI::AMQP::DEFAULT_PORT
  /home/runner/work/manageiq-cross_repo-tests/manageiq-cross_repo-tests/repos/ManageIQ/manageiq-providers-nuage@3c618859dc3655db13b3a59ae6ab1a41d237162b/vendor/bundle/ruby/3.0.0/gems/qpid_proton-0.37.0/lib/core/uri.rb:32: warning: previous definition of DEFAULT_PORT was here
  /home/runner/work/manageiq-cross_repo-tests/manageiq-cross_repo-tests/repos/ManageIQ/manageiq-providers-nuage@3c618859dc3655db13b3a59ae6ab1a41d237162b/vendor/bundle/ruby/3.0.0/gems/uri-1.0.1/lib/uri/common.rb:108: warning: already initialized constant URI::Schemes::AMQP
  /home/runner/work/manageiq-cross_repo-tests/manageiq-cross_repo-tests/repos/ManageIQ/manageiq-providers-nuage@3c618859dc3655db13b3a59ae6ab1a41d237162b/vendor/bundle/ruby/3.0.0/gems/uri-1.0.1/lib/uri/common.rb:108: warning: previous definition of AMQP was here
  /home/runner/work/manageiq-cross_repo-tests/manageiq-cross_repo-tests/repos/ManageIQ/manageiq-providers-nuage@3c618859dc3655db13b3a59ae6ab1a41d237162b/vendor/bundle/ruby/3.0.0/gems/qpid_proton-0.37.0/lib/core/uri.rb:41: warning: already initialized constant URI::AMQPS::DEFAULT_PORT
  /home/runner/work/manageiq-cross_repo-tests/manageiq-cross_repo-tests/repos/ManageIQ/manageiq-providers-nuage@3c618859dc3655db13b3a59ae6ab1a41d237162b/vendor/bundle/ruby/3.0.0/gems/qpid_proton-0.37.0/lib/core/uri.rb:41: warning: previous definition of DEFAULT_PORT was here
  /home/runner/work/manageiq-cross_repo-tests/manageiq-cross_repo-tests/repos/ManageIQ/manageiq-providers-nuage@3c618859dc3655db13b3a59ae6ab1a41d237162b/vendor/bundle/ruby/3.0.0/gems/uri-1.0.1/lib/uri/common.rb:108: warning: already initialized constant URI::Schemes::AMQPS
  /home/runner/work/manageiq-cross_repo-tests/manageiq-cross_repo-tests/repos/ManageIQ/manageiq-providers-nuage@3c618859dc3655db13b3a59ae6ab1a41d237162b/vendor/bundle/ruby/3.0.0/gems/uri-1.0.1/lib/uri/common.rb:108: warning: previous definition of AMQPS was here
  /home/runner/work/manageiq-cross_repo-tests/manageiq-cross_repo-tests/repos/ManageIQ/manageiq-providers-nuage@3c618859dc3655db13b3a59ae6ab1a41d237162b/vendor/bundle/ruby/3.0.0/gems/qpid_proton-0.37.0/lib/core/uri.rb:32: warning: already initialized constant URI::AMQP::DEFAULT_PORT
  /home/runner/work/manageiq-cross_repo-tests/manageiq-cross_repo-tests/repos/ManageIQ/manageiq-providers-nuage@3c618859dc3655db13b3a59ae6ab1a41d237162b/vendor/bundle/ruby/3.0.0/gems/qpid_proton-0.37.0/lib/core/uri.rb:32: warning: previous definition of DEFAULT_PORT was here
  /home/runner/work/manageiq-cross_repo-tests/manageiq-cross_repo-tests/repos/ManageIQ/manageiq-providers-nuage@3c618859dc3655db13b3a59ae6ab1a41d237162b/vendor/bundle/ruby/3.0.0/gems/uri-1.0.1/lib/uri/common.rb:108: warning: already initialized constant URI::Schemes::AMQP
  /home/runner/work/manageiq-cross_repo-tests/manageiq-cross_repo-tests/repos/ManageIQ/manageiq-providers-nuage@3c618859dc3655db13b3a59ae6ab1a41d237162b/vendor/bundle/ruby/3.0.0/gems/uri-1.0.1/lib/uri/common.rb:108: warning: previous definition of AMQP was here
  /home/runner/work/manageiq-cross_repo-tests/manageiq-cross_repo-tests/repos/ManageIQ/manageiq-providers-nuage@3c618859dc3655db13b3a59ae6ab1a41d237162b/vendor/bundle/ruby/3.0.0/gems/qpid_proton-0.37.0/lib/core/uri.rb:41: warning: already initialized constant URI::AMQPS::DEFAULT_PORT
  /home/runner/work/manageiq-cross_repo-tests/manageiq-cross_repo-tests/repos/ManageIQ/manageiq-providers-nuage@3c618859dc3655db13b3a59ae6ab1a41d237162b/vendor/bundle/ruby/3.0.0/gems/qpid_proton-0.37.0/lib/core/uri.rb:41: warning: previous definition of DEFAULT_PORT was here
  /home/runner/work/manageiq-cross_repo-tests/manageiq-cross_repo-tests/repos/ManageIQ/manageiq-providers-nuage@3c618859dc3655db13b3a59ae6ab1a41d237162b/vendor/bundle/ruby/3.0.0/gems/uri-1.0.1/lib/uri/common.rb:108: warning: already initialized constant URI::Schemes::AMQPS
  /home/runner/work/manageiq-cross_repo-tests/manageiq-cross_repo-tests/repos/ManageIQ/manageiq-providers-nuage@3c618859dc3655db13b3a59ae6ab1a41d237162b/vendor/bundle/ruby/3.0.0/gems/uri-1.0.1/lib/uri/common.rb:108: warning: previous definition of AMQPS was here
  /home/runner/work/manageiq-cross_repo-tests/manageiq-cross_repo-tests/repos/ManageIQ/manageiq-providers-nuage@3c618859dc3655db13b3a59ae6ab1a41d237162b/vendor/bundle/ruby/3.0.0/gems/qpid_proton-0.37.0/lib/core/uri.rb:32: warning: already initialized constant URI::AMQP::DEFAULT_PORT
  /home/runner/work/manageiq-cross_repo-tests/manageiq-cross_repo-tests/repos/ManageIQ/manageiq-providers-nuage@3c618859dc3655db13b3a59ae6ab1a41d237162b/vendor/bundle/ruby/3.0.0/gems/qpid_proton-0.37.0/lib/core/uri.rb:32: warning: previous definition of DEFAULT_PORT was here
  /home/runner/work/manageiq-cross_repo-tests/manageiq-cross_repo-tests/repos/ManageIQ/manageiq-providers-nuage@3c618859dc3655db13b3a59ae6ab1a41d237162b/vendor/bundle/ruby/3.0.0/gems/uri-1.0.1/lib/uri/common.rb:108: warning: already initialized constant URI::Schemes::AMQP
  /home/runner/work/manageiq-cross_repo-tests/manageiq-cross_repo-tests/repos/ManageIQ/manageiq-providers-nuage@3c618859dc3655db13b3a59ae6ab1a41d237162b/vendor/bundle/ruby/3.0.0/gems/uri-1.0.1/lib/uri/common.rb:108: warning: previous definition of AMQP was here
  /home/runner/work/manageiq-cross_repo-tests/manageiq-cross_repo-tests/repos/ManageIQ/manageiq-providers-nuage@3c618859dc3655db13b3a59ae6ab1a41d237162b/vendor/bundle/ruby/3.0.0/gems/qpid_proton-0.37.0/lib/core/uri.rb:41: warning: already initialized constant URI::AMQPS::DEFAULT_PORT
  /home/runner/work/manageiq-cross_repo-tests/manageiq-cross_repo-tests/repos/ManageIQ/manageiq-providers-nuage@3c618859dc3655db13b3a59ae6ab1a41d237162b/vendor/bundle/ruby/3.0.0/gems/qpid_proton-0.37.0/lib/core/uri.rb:41: warning: previous definition of DEFAULT_PORT was here
  /home/runner/work/manageiq-cross_repo-tests/manageiq-cross_repo-tests/repos/ManageIQ/manageiq-providers-nuage@3c618859dc3655db13b3a59ae6ab1a41d237162b/vendor/bundle/ruby/3.0.0/gems/uri-1.0.1/lib/uri/common.rb:108: warning: already initialized constant URI::Schemes::AMQPS
  /home/runner/work/manageiq-cross_repo-tests/manageiq-cross_repo-tests/repos/ManageIQ/manageiq-providers-nuage@3c618859dc3655db13b3a59ae6ab1a41d237162b/vendor/bundle/ruby/3.0.0/gems/uri-1.0.1/lib/uri/common.rb:108: warning: previous definition of AMQPS was here

Related to: https://www.github.com/ruby/uri/issues/125 ManageIQ#23260

jrafanie added the cleanup label Nov 8, 2024

jrafanie requested review from agrare, Fryguy and kbrock as code owners November 8, 2024 17:51

jrafanie force-pushed the fix-uri-1-0-1-warnings branch 2 times, most recently from 1ea126b to 35bd2c9 Compare November 8, 2024 18:06

jrafanie changed the title ~~Fix warnings raised by URI 1.0.1~~ [WIP] Fix warnings raised by URI 1.0.1 Nov 8, 2024

jrafanie force-pushed the fix-uri-1-0-1-warnings branch from 733c1f4 to e4e6169 Compare November 8, 2024 18:13

miq-bot pushed a commit to ManageIQ/manageiq-cross_repo-tests that referenced this pull request Nov 8, 2024

Running tests for jrafanie

ece0342

From Pull Request: ManageIQ/manageiq#23261

miq-bot mentioned this pull request Nov 8, 2024

[BOT] Cross repo test for ManageIQ/manageiq#23261 ManageIQ/manageiq-cross_repo-tests#928

Open

jrafanie force-pushed the fix-uri-1-0-1-warnings branch from e4e6169 to b1a2248 Compare November 11, 2024 14:48

jrafanie added the wip label Nov 11, 2024

jrafanie added 2 commits November 20, 2024 15:10

Fix warnings raised by URI 1.0.1

e4c72e7

Related to: https://www.github.com/ruby/uri/issues/125 ManageIQ#23260

Use newer URI so we can stay current and fix deprecations

8b65989

jrafanie force-pushed the fix-uri-1-0-1-warnings branch from b1a2248 to 8b65989 Compare November 20, 2024 20:11

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WIP] Fix warnings raised by URI 1.0.1 #23261

[WIP] Fix warnings raised by URI 1.0.1 #23261

jrafanie commented Nov 8, 2024 •

edited

Loading

jrafanie commented Nov 8, 2024

jrafanie commented Nov 8, 2024 •

edited

Loading

kbrock commented Nov 11, 2024

jrafanie commented Nov 11, 2024

jrafanie commented Nov 11, 2024 •

edited

Loading

[WIP] Fix warnings raised by URI 1.0.1 #23261

Are you sure you want to change the base?

[WIP] Fix warnings raised by URI 1.0.1 #23261

Conversation

jrafanie commented Nov 8, 2024 • edited Loading

jrafanie commented Nov 8, 2024

jrafanie commented Nov 8, 2024 • edited Loading

kbrock commented Nov 11, 2024

jrafanie commented Nov 11, 2024

jrafanie commented Nov 11, 2024 • edited Loading

jrafanie commented Nov 8, 2024 •

edited

Loading

jrafanie commented Nov 8, 2024 •

edited

Loading

jrafanie commented Nov 11, 2024 •

edited

Loading