Adding callbacks #344
Open
Adding callbacks #344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New events fired when: - item moves down - item floats up - item resized stop - item drag stop
Added resizing callback. Changed resized stop callback call.
Added events for the tests
|
It looks like you accidentally committed your changes to package.json. Please fix and push. |
Remove package.json wrong changes.
Updated package name, changes.
Remove updated version.
|
Done! Sorry for that. Do I need to create another pull request? |
|
No, this PR is still valid. |
angular-gridster has problems when the number of colums/rows are big. I merged coryasilva login from his pull-request and the performance now is great. I will be waiting for this and coryasilva pull request to be merged into the main repo.
Event thrown when the layout changes. This is added to save the boxes layout.
Added gridsterItemSizeChanged when gridster item position changed
|
Sorry for the delay on reviewing this. I can't read the diff because it shows the entire file as changed. Did you run some kind of formatter on the JS? |
|
The whitespace issues need to be resolved before this can be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New callbacks in gridsterItem directive. This callbacks are added inside bindToController object of the directive with the &.
For example:
bindToController:{
......
gridsterItemDragStop: '&'
......
}
This is called inside dragStop function.
From the outside it can be used as:
<li gridster-item gridster-item-drag-stop:'ctrller.doSomethingOnDragStop()'></li>