-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/event on scroll #452
Open
zouberakis
wants to merge
31
commits into
ManifestWebDesign:master
Choose a base branch
from
zouberakis:feature/event-on-scroll
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Feature/event on scroll #452
zouberakis
wants to merge
31
commits into
ManifestWebDesign:master
from
zouberakis:feature/event-on-scroll
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…callback that invokes the viewportNotify on every item in the grid. Plus exposes viewport related methods on gridster items, to be used on 'gridster-item-viewport-status' event.
…d party dependencies)
…ery floatItems up invocation
…unce && ditches A $timed-out scope.$apply
…bit smoother on the eye.
Files changed 21. Line changes +4,401 −1,801. No way you're getting anyone to review this. |
True that, but I simply could not work on a single js file :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a way to notify when gridster item is in viewport. That way heavy gridster items can delay rendering when in viewport. Also took the code apart as it was difficult to manage in one big file/