Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new resize & drag events #459

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ste2425
Copy link

@ste2425 ste2425 commented Nov 10, 2016

Adding new events:

Resize Start
Resize End
Drag start
Drag End

Note: The end events are triggered before the transition animations complete, when the user lifts the mouse button.

There are currently callback for these events but this are at a global level to the Gridster Items.

For Project i need to be notified within the scope of the Gridtser-Item directive of these activities. This provides the neatest solution to that.

Thanks

@ste2425
Copy link
Author

ste2425 commented Nov 10, 2016

I noticed i had written the drag-end event wrong in the readme. I can squash the commits together if required. However I'm not too sure what that would mean for the PR. Would i need to close and recreate it, or can i force push and it will sort itself out?

@prettycode
Copy link

+1 Would love to see this merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants