-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Improve line rendering performance by decreasing redundant subdivisio…
…n count (#3893) * Reduce line cylinder height resolution to 2 Subdividing a line cylinder by its height adds no extra resolution - since it's not checkerboarded, all new rectangles would look the same as one long rectangle. Decreasing the default subdivision resolution to 2 reduces submobject count by 12x while sacrificing no quality. * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Allow for 2 resolution values in Line3D This prevents a breaking change where a tuple of resolution values passed to Line3D.resolution would no longer work. Also applies to Arrow3D. * Assign field before init * Add checkered line info to docstring * Regenerate test control frame * Regenerate missing control frames --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Francisco Manríquez Novoa <[email protected]>
- Loading branch information
1 parent
fc58a46
commit ce1fff6
Showing
17 changed files
with
18 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file modified
BIN
+0 Bytes
(100%)
tests/test_graphical_units/control_data/threed/AddFixedInFrameMobjects.npz
Binary file not shown.
Binary file modified
BIN
+0 Bytes
(100%)
tests/test_graphical_units/control_data/threed/AmbientCameraMove.npz
Binary file not shown.
Binary file modified
BIN
-244 Bytes
(90%)
tests/test_graphical_units/control_data/threed/Arrow3D.npz
Binary file not shown.
Binary file not shown.
Binary file modified
BIN
+0 Bytes
(100%)
tests/test_graphical_units/control_data/threed/CameraMove.npz
Binary file not shown.
Binary file modified
BIN
+0 Bytes
(100%)
tests/test_graphical_units/control_data/threed/CameraMoveAxes.npz
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file modified
BIN
+0 Bytes
(100%)
tests/test_graphical_units/control_data/threed/Cylinder.npz
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file modified
BIN
+0 Bytes
(100%)
tests/test_graphical_units/control_data/threed/MovingVertices.npz
Binary file not shown.
Binary file not shown.
Binary file modified
BIN
+0 Bytes
(100%)
tests/test_graphical_units/control_data/threed/SurfaceColorscale.npz
Binary file not shown.
Binary file not shown.
Binary file modified
BIN
+0 Bytes
(100%)
tests/test_graphical_units/control_data/threed/Y_Direction.npz
Binary file not shown.