Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typing progress tracker #3375

Open
8 of 22 tasks
Viicos opened this issue Sep 22, 2023 · 4 comments
Open
8 of 22 tasks

Typing progress tracker #3375

Viicos opened this issue Sep 22, 2023 · 4 comments
Labels

Comments

@Viicos
Copy link
Member

Viicos commented Sep 22, 2023

This issue is meant to track progress related to adding type hints to the library.

Fixes:

Progress (layout subject to changes):

Contributing

Contribution guidelines can be found here (TODO).

This issue can be used for any questions (Discord is good place as well).

When starting working on a new module, you can tweak the ignore_errors value in the mypy.ini configuration file:

manim/.mypy.ini

Lines 4 to 6 in c6450b2

# ignore most files; should be checked once proper types have been implemented
[mypy-manim.__main__]
ignore_errors = True

@to-sta
Copy link

to-sta commented Sep 23, 2023

Happy to help here 😊.

@Viicos
Copy link
Member Author

Viicos commented Sep 24, 2023

Happy to help here 😊.

Nice, #3086 will bring some typing guidelines, though I still need to add more info I guess. Once merged, I'll review the typed modules individually. Feel free to tell which module you'd like to work on (after #3086 gets merged)

@JasonGrace2282
Copy link
Member

Planning on bringing the typing docs up to date when I have time :)

@henrikmidtiby
Copy link
Contributor

There are also work on adding types to the utils module #3999
and to the files in manim/scene/*.py #3981

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: 🆕 New
Development

No branches or pull requests

5 participants