Add type hints to manim.cli module
#3988
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
Could you remove this module from mypy's ignore list? https://github.com/ManimCommunity/manim/blob/main/mypy.ini#L61-L63 |
|
Done! |
|
I'll have to fix the MyPy errors later. |
|
I fixed all the errors reported by
|
| # No command name matched. | ||
| ctx.arg0 = cmd_name | ||
| ctx.meta["arg0"] = cmd_name |
There was a problem hiding this comment.
Didn't know about this, nice change :)
There was a problem hiding this comment.
Thanks! I was struggling to do this assignment without having mypy complain about it, so I ended up looking at click.Context in the hope of finding some dictionary, which I fortunately found!
JasonGrace2282
changed the title
climanim.cli module
manim/cli/render/render_options.py
Outdated
| start, end = map(int, re.split(r"[;,\-]", value)) | ||
| except Exception: | ||
| logger.error("Couldn't determine a range for -n option.") | ||
| exit() |
There was a problem hiding this comment.
We should probably use sys.exit here, exit() is only intended for use in the REPL.
There was a problem hiding this comment.
Right! I just made that change.
As required by the issue #3375, I added typings for the
manim.climodule.I also added an entry in the docs for the
climodule, although it's a work in progress.Links to added or changed documentation pages
Reviewer Checklist