Fix AttributeError and ValueError in Bezier and Interpolation functions #3372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Fixed AttributeError in get_bezier_tuples_from_points function: - Converted 'points' list to a NumPy array before using the reshape method to prevent AttributeError. 2. Fixed ValueError in interpolate function: - Corrected a typo in the if condition from `len(tri1) != len(tri1)` to `len(tri1) != len(tri2)`. - Added a shape check before using `np.all(tri1 == tri2)` to prevent broadcasting issues and subsequent ValueError when comparing arrays of different shapes.
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
behackl
requested changes
Oct 22, 2023
| @@ -10,11 +10,13 @@ | |||
|
|
|||
| import moderngl | |||
| import numpy as np | |||
| from colour import Color | |||
|
Stale for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed AttributeError in get_bezier_tuples_from_points function:
Fixed ValueError in interpolate function:
len(tri1) != len(tri1)tolen(tri1) != len(tri2).np.all(tri1 == tri2)to prevent broadcasting issues and subsequent ValueError when comparing arrays of different shapes.Overview: What does this pull request change?
The pull request includes important bugfixes in
get_bezier_tuples_from_pointsandinterpolatefunctions, enhancing the reliability and robustness of the library.Motivation and Explanation: Why and how do your changes improve the library?
These changes improve the library by preventing errors that were occurring due to the misuse of list methods and broadcasting issues. These fixes make the
get_bezier_tuples_from_pointsandinterpolatefunctions more robust, and prevent crashes that would occur under specific conditions.Links to added or changed documentation pages
Documentation not affected by these changes.
Further Information and Comments
Thank you for considering this pull request. I believe these changes will greatly enhance the reliability of the mentioned functions.
Reviewer Checklist