Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow :meth:.VGroup.add to use iterables of VMobjects #3556

Closed
wants to merge 8 commits into from
Closed

Allow :meth:.VGroup.add to use iterables of VMobjects #3556

wants to merge 8 commits into from

Conversation

JasonGrace2282
Copy link
Member

@JasonGrace2282 JasonGrace2282 commented Dec 29, 2023 •
edited
Loading

Closes #3540

Allows for statements like:

VGroup(
    Square(),
    [Circle()],
    (x.shift(RIGHT) for x in [Star(), Triangle()])
)

Also added a test for this.

As MrDiver said, it's annoying to have to unpack iterables with the * operator.

@JasonGrace2282 JasonGrace2282 added the new feature Enhancement specifically adding a new feature (feature request should be used for issues instead) label Dec 29, 2023
@JasonGrace2282 JasonGrace2282 added this to the v0.18.1 milestone Dec 29, 2023
@JasonGrace2282 JasonGrace2282 marked this pull request as draft December 29, 2023 03:32
@JasonGrace2282 JasonGrace2282 changed the title :meth:.Mobject.add allows iterables of Mobjects Allow :meth:.VGroup.add to use iterables of VMobjects Dec 29, 2023
JasonGrace2282 and others added 4 commits December 28, 2023 23:13
@JasonGrace2282
Hopefully fix tests?
f63e1f8 
Turns out VGroups (and all things it inherits from) are iterables... oops!
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
4f28811 
for more information, see https://pre-commit.ci
@JasonGrace2282
Found error in logic
ce92252
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
dd0c9af 
for more information, see https://pre-commit.ci
github-advanced-security[bot]
github-advanced-security bot found potential problems Dec 29, 2023
View reviewed changes
manim/mobject/types/vectorized_mobject.py
@@ -31,6 +31,7 @@
from typing_extensions import Self

from manim.mobject.opengl.opengl_compatibility import ConvertToOpenGL
from manim.mobject.opengl.opengl_mobject import OpenGLMobject

Check notice

Code scanning / CodeQL

Cyclic import Note

Import of module
manim.mobject.opengl.opengl_mobject
Loading
begins an import cycle.
@JasonGrace2282 JasonGrace2282 removed this from the v0.18.1 milestone Jan 15, 2024
@JasonGrace2282
Copy link
Member Author

Closing this as the performance hit for checking if an object is not a VMobject is a bit excessive.

@JasonGrace2282 JasonGrace2282 deleted the vgroup_iterables branch February 1, 2024 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrDiver MrDiver Awaiting requested review from MrDiver

Assignees
No one assigned
Labels
new feature Enhancement specifically adding a new feature (feature request should be used for issues instead)
Projects
Dev Board
Status: ❌ Rejected
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

VGroup should parse iterables
1 participant
@JasonGrace2282