-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix DiGraph
edges not fading correctly on FadeIn
and FadeOut
#3786
Fix DiGraph
edges not fading correctly on FadeIn
and FadeOut
#3786
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution! Looks good in general, just one small comment.
Co-authored-by: Francisco Manríquez Novoa <[email protected]>
@chopan050 Thanks for the edit! Side note: I'm interested in helping with the rewrite, do you know how I could get into that? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Any help is greatly appreciated! Simply join #dev-chat on the Manim Discord server, or the [manim/experimental] post on #development, and say that you're interested in helping. Somewhere in that post there's a list of the current tasks we have to do in experimental. |
DiGraph
edges not fading correctly on FadeIn
and FadeOut
Feel free to ping me on Discord (I'm still @JasonGrace2282 ) if you want me to walk you through where we are right now in the rewrite :) |
Overview: What does this pull request change?
This pull request resolves issue #3749 in which edges do not FadeOut properly when using DiGraph. The default updater in the DiGraph class used the edge constructor
.become
to attach the edges to the vertices. I replaced the updater to function more similarly to the Graph updater which moves the endpoints of the Line. Also, noticed thatLine::set_points_by_ends
did not project onto the bounding box ofstart
andend
so I updated the behavior to match the constructor and the type hints to align with usage in the example scenes.Line::set_points_by_ends
Line
graph.py
to useLine::set_points_by_ends
instead of.become
Links to added or changed documentation pages
https://manimce--3786.org.readthedocs.build/en/3786/reference/manim.mobject.geometry.line.Line.html#manim.mobject.geometry.line.Line.set_points_by_ends
Further Information and Comments
Fixes #3749
Reviewer Checklist