-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite installation instructions #3930
Rewrite installation instructions #3930
Conversation
I wonder whether we should collapse the installation instructions for Windows / MacOS / Linux back onto one single page and make use of code tabs https://sphinx-design.readthedocs.io/en/furo-theme/tabs.html#tabbed-code-examples to switch out the respective instructions? With all the externally managed Python environments around it might also be worth considering just recommending an installation via uv; |
Just took a look and it looks amazing! Definitely agree with using tabs for different operating systems.
The idea of just
And then most IDE's will recognize that a Or we could just not use uv :) |
I just pushed a commit changing the recommendation to |
I very much like what you have done here, thank you for your efforts! After some more thinking, there are some details I would change (I can push a commit -- or a separate branch for a 1:1 comparison):
But all in all, I definitely agree that this sort of unified set of instructions is the way to go. We should look into setting up redirects from the old /windows, /linux, /macos pages to the new /local (or /pip?) page, otherwise we will break a lot of static guides. |
Feel free to push a commit, I probably won't be able to work on this PR until next weekend. |
for more information, see https://pre-commit.ci
I've pushed a somewhat orthogonal suggestion to this branch, the corresponding site is available at https://manimce--3930.org.readthedocs.build/en/3930/installation/pip.html. I have not verified that all of the linux instructions really work exactly like they are stated here, but all in all I am pretty happy with where this is moving. I largely drew from @JasonGrace2282's first draft and tried to trim a few (in my opinion) superfluous branches while trying to keep the standard case somewhat succinct. |
…nstallation-rewrite
The installation guide for uv is now available here: https://manimce--3930.org.readthedocs.build/en/3930/installation/uv.html |
I've done some additional polishing, removed v1 (as it seemed to be the general preference of everyone who participated so far -- otherwise we can of course revert my last commit) -- and am generally happy with the state of things here. I'll ask for one more round of feedback of all helpers, but would then like to merge this (and move closer to actually making the release). As I've said a bunch of times before, it'd be nice to lower the barrier for making a patch release so that we can update the stable version of these docs more frequently (and I think we decided that this was a good idea too). |
…m into installation-rewrite
for more information, see https://pre-commit.ci
…m into installation-rewrite
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested the redirects, everything seems to be working.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, Benjamin, for pushing the PR forward!
I left one or two comments from a quick readthrough, but overall, I'm happy to merge it in its current state.
* First draft of Changelog for 0.19.0 * fix typos * added 3967 * Add #4037 * Update count 97 -> 98 * Add #4039 * Add #3930 and #4044 * Add this PR to changelog * Add small description to changelog * Add #3924, #3951, and #4038 * Bump Manim version to 0.19.0 * Update CITATION.cff to be more consistent * remove github-security[bot] * Feedback + missing PRs * add newly merged PRs * added more details to highlights + breaking changes * bump date * sort PRs in breaking changes section and include 3964 * sort highlights section * fix: add required configuration key in .readthedocs.yml * Update docs/source/changelog/0.19.0-changelog.rst --------- Co-authored-by: Benjamin Hackl <[email protected]>
#3501 removed the ffmpeg dependency - this meant that our installation docs could be drastically simplified. This an attempt to do that. Specifically
Leaves Optional Dependency stuff in their own file depending on the system.EDIT: They're now in tabs - see behackl's commentFurther improvement ideas welcome!
Also closes #3864
https://manimce--3930.org.readthedocs.build/en/3930/installation/local.html