Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create changelog for 0.19.0 #4032

Merged
merged 21 commits into from
Jan 20, 2025
Merged

Create changelog for 0.19.0 #4032

merged 21 commits into from
Jan 20, 2025

Conversation

JasonGrace2282
Copy link
Member

@JasonGrace2282 JasonGrace2282 commented Dec 1, 2024 •
edited
Loading

@JasonGrace2282 JasonGrace2282 added the maintenance refactoring, typos, removing clutter/dead code, and other code quality improvements label Dec 1, 2024
@JasonGrace2282 JasonGrace2282 added this to the v0.19.0 milestone Dec 1, 2024
@JasonGrace2282 JasonGrace2282 marked this pull request as draft December 6, 2024 23:59
@JasonGrace2282 JasonGrace2282 marked this pull request as ready for review December 17, 2024 00:28
chopan050
chopan050 reviewed Jan 10, 2025
View reviewed changes
Copy link
Contributor

@chopan050 chopan050 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I left some comments around.

docs/source/changelog/0.19.0-changelog.rst Outdated Show resolved Hide resolved
docs/source/changelog/0.19.0-changelog.rst Outdated Show resolved Hide resolved
docs/source/changelog/0.19.0-changelog.rst Outdated Show resolved Hide resolved
behackl
behackl approved these changes Jan 19, 2025
View reviewed changes
Copy link
Member

@behackl behackl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added all the PRs that have been merged since the changelog has been edited the last time, did a pass to improve consistency in the formatting, and added extended descriptions for all highlight / breaking changes PRs.

From my point of view, I'm happy with this, my changes should be cross-checked before this is merged. We should also not merge any other PRs at this point (except a critical bug shows up) until the release is done.

Great job everyone!

chopan050
chopan050 reviewed Jan 20, 2025
View reviewed changes
Copy link
Contributor

@chopan050 chopan050 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before uploading this, could we correct a typo and discuss whether not needing to use config["media_embed"] = True in Colab might be a highlight?

docs/source/changelog/0.19.0-changelog.rst Outdated Show resolved Hide resolved
docs/source/changelog/0.19.0-changelog.rst Show resolved Hide resolved
@behackl behackl added the release A tracking issue for changes expected for a release label Jan 20, 2025
@behackl behackl merged commit c2dfb59 into ManimCommunity:main Jan 20, 2025
21 checks passed
@JasonGrace2282 JasonGrace2282 deleted the 0.19.0 branch January 20, 2025 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chopan050 chopan050 chopan050 left review comments

@behackl behackl behackl approved these changes

Assignees
No one assigned
Labels
maintenance refactoring, typos, removing clutter/dead code, and other code quality improvements release A tracking issue for changes expected for a release
Projects
Dev Board
Status: ✅ Done
Milestone
v0.19.0
Development

Successfully merging this pull request may close these issues.
3 participants
@JasonGrace2282 @behackl @chopan050