Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force collator offline #1361

Merged
merged 5 commits into from
Feb 14, 2025
Merged

Force collator offline #1361

merged 5 commits into from
Feb 14, 2025

Conversation

Dengjianping
Copy link
Contributor

@Dengjianping Dengjianping commented Feb 10, 2025

Description


Before we can approve this PR for merge, please make sure that all the following items have been checked off:

  • Connected to an issue with discussion and accepted design using zenhub "Connect issue" button below
  • Added one label out of the L- group to this PR
  • Added one or more labels from the A- and C- groups to this PR
  • Explicitly labelled A-calamari and/or A-manta if your changes are meant for/impact either of these (CI depends on it)
  • Re-reviewed Files changed in the Github PR explorer.
  • Add A-integration-test-checks to run start-integration-test-checks (Required)
  • Add A-benchmark-checks to run start-benchmark-check (Required)
  • Add A-unit-test-checks to run start-unit-test-checks (Required)
  • Add A-congestion-test-checks to run start-integration-test-checks (Optional)

Situational Notes:

  • If adding functionality, write unit tests!
  • If importing a new pallet, choose a proper module index for it, and allow it in BaseFilter. Ensure every extrinsic works from front-end. If there's corresponding tool, ensure both work for each other.
  • If needed, update our Javascript/Typescript APIs. These APIs are officially used by exchanges or community developers.
  • If modifying existing runtime storage items, make sure to implement storage migrations for the runtime and test them with try-runtime. This includes migrations inherited from upstream changes, and you can search the diffs for modifications of #[pallet::storage] items to check for any.

@Dengjianping Dengjianping added A-calamari Area: Issues and PRs related to the Calamari Runtime A-runtime Area: Issues and PRs related to Runtimes A-unit-test-checks labels Feb 10, 2025
@Dengjianping Dengjianping changed the title Force collator online or offline Force collator online and offline Feb 10, 2025
@Dengjianping Dengjianping added L-added Log: Issues and PRs related to addition C-enhancement Category: An issue proposing an enhancement or a PR with one A-benchmark-checks A-integration-test-checks labels Feb 10, 2025
Signed-off-by: Jamie <[email protected]>
Signed-off-by: Jamie <[email protected]>
Signed-off-by: Jamie <[email protected]>
@Dengjianping Dengjianping changed the title Force collator online and offline Force collator offline Feb 14, 2025
@Dengjianping Dengjianping merged commit 67e9473 into manta Feb 14, 2025
17 of 19 checks passed
@Dengjianping Dengjianping deleted the force-offline-collator branch February 14, 2025 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-benchmark-checks A-calamari Area: Issues and PRs related to the Calamari Runtime A-integration-test-checks A-runtime Area: Issues and PRs related to Runtimes A-unit-test-checks C-enhancement Category: An issue proposing an enhancement or a PR with one L-added Log: Issues and PRs related to addition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants