-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auto-enforce code formatting #590
Conversation
Signed-off-by: Dengjianping <[email protected]>
Signed-off-by: Dengjianping <[email protected]>
Signed-off-by: Dengjianping <[email protected]>
Signed-off-by: Dengjianping <[email protected]>
Signed-off-by: Dengjianping <[email protected]>
Signed-off-by: Dengjianping <[email protected]>
Signed-off-by: Dengjianping <[email protected]>
Signed-off-by: Georgi Zlatarev <[email protected]>
Signed-off-by: Georgi Zlatarev <[email protected]>
Signed-off-by: Georgi Zlatarev <[email protected]>
Signed-off-by: Georgi Zlatarev <[email protected]>
Signed-off-by: Georgi Zlatarev <[email protected]>
Signed-off-by: Georgi Zlatarev <[email protected]>
Signed-off-by: Adam Reif <[email protected]>
Signed-off-by: Adam Reif <[email protected]>
Signed-off-by: Adam Reif <[email protected]>
Signed-off-by: Adam Reif <[email protected]>
…randor/reformat Signed-off-by: Adam Reif <[email protected]>
Signed-off-by: Adam Reif <[email protected]>
Signed-off-by: Adam Reif <[email protected]>
Signed-off-by: Adam Reif <[email protected]>
Makes sure denies take precedence over allows Signed-off-by: Adam Reif <[email protected]>
Signed-off-by: Adam Reif <[email protected]>
Signed-off-by: Adam Reif <[email protected]>
I don't have a strong opinion either way. As long as |
The PR is finished, but please don't review yet as the changes from #572 are still listed as changes here. When you DO review, use "hide whitespace" mode -> https://github.com/Manta-Network/Manta/pull/590/files?diff=unified&w=1 |
Signed-off-by: Adam Reif <[email protected]>
Signed-off-by: Adam Reif <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I looked it over, the changeset looks good to me.
Some of the automatic formatting is a bit wonky where it inserted new-lines fairly pointlessly, but that's autoformatting i guess ¯_(ツ)_/¯
Signed-off-by: Adam Reif <[email protected]>
Signed-off-by: Adam Reif <[email protected]>
Signed-off-by: Adam Reif <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gone through again, space indented files look sane
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Signed-off-by: Boyuan Feng <[email protected]>
Signed-off-by: Boyuan Feng <[email protected]>
Merge after #572
Only semi-significant change besides the formatting is in the manta/calamari/dolphin RT where i reordered the CallFilter to lead the match with explicitly disallowed extrinsics for safety on refactor.
=> https://github.com/Manta-Network/Manta/pull/590/files#diff-3c21538b15b471a2e041d55e54f471aca028763b85b77a8c30ed31409dd49a27R185
Use https://github.com/Manta-Network/Manta/pull/590/files?diff=unified&w=1 to see only the functional changes
Description
closes #584
closes #586
closes #310
closes #307
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
<branch>/CHANGELOG.md
Files changed
in the Github PR explorer.authoring_version
: The version of the authorship interface. An authoring node will not attempt to author blocks unless this is equal to its native runtime.spec_version
: The version of the runtime specification. A full node will not attempt to use its native runtime in substitute for the on-chain Wasm runtime unless all of spec_name, spec_version, and authoring_version are the same between Wasm and native.impl_version
: The version of the implementation of the specification. Nodes are free to ignore this; it serves only as an indication that the code is different; as long as the other two versions are the same then while the actual code may be different, it is nonetheless required to do the same thing. Non-consensus-breaking optimizations are about the only changes that could be made which would result in only the impl_version changing.transaction_version
: The version of the extrinsics interface. This number must be updated in the following circumstances: extrinsic parameters (number, order, or types) have been changed; extrinsics or pallets have been removed; or the pallet order in the construct_runtime! macro or extrinsic order in a pallet has been changed. You can run themetadata_diff.yml
workflow for help. If this number is updated, then thespec_version
must also be updatedBaseFilter
. Ensure every extrinsic works from front-end. If there's corresponding tool, ensure both work for each other.try-runtime
. This includes migrations inherited from upstream changes, and you can search the diffs for modifications of#[pallet::storage]
items to check for any.