Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update docs, add simple test #28

Closed
wants to merge 3 commits into from
Closed

update docs, add simple test #28

wants to merge 3 commits into from

Conversation

ajshedivy
Copy link
Collaborator

@ajshedivy ajshedivy commented Jul 16, 2024 •
edited
Loading

Fixes #
#36

Changes proposed in this pull request:

  • update docs with dev environment setup
  • add local test suite using pytest
  • use pytest-env to store login info

Before submitting

  • I've read and followed all steps in the Making a pull request
    section of the CONTRIBUTING docs.
  • I've updated or added any relevant docstrings following the syntax described in the
    Writing docstrings section of the CONTRIBUTING docs.
  • If this PR fixes a bug, I've added a test that will fail without my fix.
  • If this PR adds a new feature, I've added tests that sufficiently cover my new functionality.

@ajshedivy ajshedivy requested a review from irfanshar July 16, 2024 17:41
@irfanshar
Copy link
Contributor

Suggestion for macos users:

Maybe have their venv setup command to be

python3.11 -m venv .venv rather than python3 -m venv .venv

@ThePrez ThePrez added this to the Tech Preview 1 milestone Jul 31, 2024
@ajshedivy ajshedivy closed this Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@irfanshar irfanshar irfanshar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Tech Preview 1
Development

Successfully merging this pull request may close these issues.
3 participants
@ajshedivy @irfanshar @ThePrez