Fix miTransitionLevel using recoil #441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
packages/react-components/src/components/MIMap/MapboxMap/MapboxMap.jsx
Outdated
Show resolved
Hide resolved
…xMap.jsx Co-authored-by: Anders Mogensen <[email protected]>
|
Suggestion applied @ammapspeople |
packages/react-components/src/components/MIMap/MapboxMap/MapboxMap.jsx
Outdated
Show resolved
Hide resolved
| * React on changes in the miTransitionLevel prop. | ||
| */ | ||
| useEffect(() => { | ||
| setMapOptions({ miTransitionLevel: miTransitionLevel}) |
There was a problem hiding this comment.
To avoid the unexpected, maybe try to only set the property and value of the miTransitionLevel is a number (or can be parsed to a number).
…xMap.jsx Co-authored-by: Anders Mogensen <[email protected]>
|
@ammapspeople I pushed a small fix that @andreeaceachir142 found. |
andreeaceachir142
deleted the
bugfix/fix_mitransitionlevel_breaking_react_components
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I removed using atoms inside MapboxMap.jsx
I made it so miTransitionLevel is respected in MapboxMap.jsx, if defined in the URL.