Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Implement App Config v2 #457

Open
wants to merge 33 commits into
base: release/app_config_v2
Choose a base branch
from

Conversation

matbmapspeople
Copy link
Contributor

@matbmapspeople matbmapspeople commented Jan 31, 2025

This merge request skips logic to deal with mapboxAccessToken or gmKey.

It should cover: language, primaryColor, logo, venue, startZoomLevel, pitch and bearing props.

In order to make primaryColor and logo work, I needed to remove their default values from MapsIndoorsMap.jsx and add them to MapTemplate.jsx. It is because we need to follow a proper priority: URL prop > App Config > default value (in this case)

@matbmapspeople matbmapspeople self-assigned this Jan 31, 2025
@matbmapspeople matbmapspeople changed the base branch from main to release/app_config_v2 January 31, 2025 13:31
@matbmapspeople
Copy link
Contributor Author

matbmapspeople commented Feb 3, 2025

@ammapspeople I just figured out that there is no work to be done for Mapbox/Google Maps API keys. When @andreeaceachir142 removes default ones from the buckets, we either set up one from URL or App Config:

Screenshot 2025-02-03 at 14 03 51

Copy link
Contributor

@ammapspeople ammapspeople left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we think of any general way to get a value when investigating the "prop > app config > default" chain?

@matbmapspeople
Copy link
Contributor Author

I have addressed your comments @ammapspeople

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants