-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: Implement App Config v2 #457
base: release/app_config_v2
Are you sure you want to change the base?
feature: Implement App Config v2 #457
Conversation
…thing defined in the url
@ammapspeople I just figured out that there is no work to be done for Mapbox/Google Maps API keys. When @andreeaceachir142 removes default ones from the buckets, we either set up one from URL or App Config: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we think of any general way to get a value when investigating the "prop > app config > default" chain?
packages/map-template/src/components/MapTemplate/MapTemplate.jsx
Outdated
Show resolved
Hide resolved
packages/map-template/src/components/MapTemplate/MapTemplate.jsx
Outdated
Show resolved
Hide resolved
packages/map-template/src/components/MapTemplate/MapTemplate.jsx
Outdated
Show resolved
Hide resolved
packages/map-template/src/components/MapTemplate/MapTemplate.jsx
Outdated
Show resolved
Hide resolved
packages/map-template/src/components/MapTemplate/MapTemplate.jsx
Outdated
Show resolved
Hide resolved
packages/map-template/src/components/MapTemplate/MapTemplate.jsx
Outdated
Show resolved
Hide resolved
packages/map-template/src/components/MapTemplate/MapTemplate.jsx
Outdated
Show resolved
Hide resolved
packages/map-template/src/components/MapTemplate/MapTemplate.jsx
Outdated
Show resolved
Hide resolved
packages/map-template/src/components/MapTemplate/MapTemplate.jsx
Outdated
Show resolved
Hide resolved
packages/map-template/src/components/MapTemplate/MapTemplate.jsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Anders Mogensen <[email protected]>
Co-authored-by: Anders Mogensen <[email protected]>
Co-authored-by: Anders Mogensen <[email protected]>
Co-authored-by: Anders Mogensen <[email protected]>
Co-authored-by: Anders Mogensen <[email protected]>
Co-authored-by: Anders Mogensen <[email protected]>
Co-authored-by: Anders Mogensen <[email protected]>
Co-authored-by: Anders Mogensen <[email protected]>
Co-authored-by: Anders Mogensen <[email protected]>
Co-authored-by: Anders Mogensen <[email protected]>
I have addressed your comments @ammapspeople |
packages/map-template/src/components/MapTemplate/MapTemplate.jsx
Outdated
Show resolved
Hide resolved
packages/map-template/src/components/MapTemplate/MapTemplate.jsx
Outdated
Show resolved
Hide resolved
packages/map-template/src/components/MapTemplate/MapTemplate.jsx
Outdated
Show resolved
Hide resolved
packages/map-template/src/components/MapTemplate/MapTemplate.jsx
Outdated
Show resolved
Hide resolved
packages/map-template/src/components/MapTemplate/MapTemplate.jsx
Outdated
Show resolved
Hide resolved
packages/map-template/src/components/MapTemplate/MapTemplate.jsx
Outdated
Show resolved
Hide resolved
packages/map-template/src/components/MapTemplate/MapTemplate.jsx
Outdated
Show resolved
Hide resolved
packages/map-template/src/components/MapTemplate/MapTemplate.jsx
Outdated
Show resolved
Hide resolved
packages/map-template/src/components/MapsIndoorsMap/MapsIndoorsMap.jsx
Outdated
Show resolved
Hide resolved
packages/map-template/src/components/MapsIndoorsMap/MapsIndoorsMap.jsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Anders Mogensen <[email protected]>
Co-authored-by: Anders Mogensen <[email protected]>
…sMap.jsx Co-authored-by: Anders Mogensen <[email protected]>
…sMap.jsx Co-authored-by: Anders Mogensen <[email protected]>
This merge request skips logic to deal with mapboxAccessToken or gmKey.
It should cover:
language
,primaryColor
,logo
,venue
,startZoomLevel
,pitch
andbearing
props.In order to make
primaryColor
andlogo
work, I needed to remove their default values from MapsIndoorsMap.jsx and add them to MapTemplate.jsx. It is because we need to follow a proper priority: URL prop > App Config > default value (in this case)