Feature: share button in location details #459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… directions link. We now store the link to be used for the QR code in an atom.
…ith copying or by QR code.
…e disappears when the user clicks outside it.
…r better reusability.
…d query parameters.
ammapspeople
requested review from
matbmapspeople,
andreeaceachir142 and
Lucaci-Andrei
packages/map-template/src/components/LocationDetails/ShareLocationLink/ShareLocationLink.jsx
Outdated
Show resolved
Hide resolved
|
Really nice and clean implementation @ammapspeople 🙌 |
andreeaceachir142
approved these changes
Feb 7, 2025
Lucaci-Andrei
approved these changes
Feb 7, 2025
matbmapspeople
approved these changes
Feb 7, 2025
|
I added two more commits. If someone can take a look and approve, it would be very much appreciated. |
|
Looks good to me 👍 |
|
All good from my side ✅ @ammapspeople |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Adds share functionality in the Location Details, making it possible for the user to copy a link to the clipboard or scan a QR code. The link will open the Map Template with current Location as a query parameter.
How
baseLink.QRCodeDialogcomponent to be more general instead of coupled to directions link.showQRCodeDialogStateboolean to aqrCodeLinkStatecontaining the link, which also acts as a trigger to show the QR code dialog.Directionscomponent, set the share directions link using theqrCodeLinkState, thus triggering the QR Code Dialog.ShareLocationLink, with buttons for copying a link to a clipboard or activating the QR code dialog.react-click-away-listenerto help detecting when the user clicks outside the ShareLocationLink UI - in that case, we want to close it.