-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/remove You-have-arrived-step #461
base: main
Are you sure you want to change the base?
Conversation
packages/components/src/components/route-instructions-step/route-instructions-step.tsx
Show resolved
Hide resolved
@matbmapspeople in the ![]() ![]() |
@matbmapspeople this should be a minor, not a patch. It's not a feature addition, but it's a feature change. It's not really a bug that is being fixed. 🙏 |
@matbmapspeople also remember to update the changelog for the components before merging this into main. ![]() vs |
@matbmapspeople is the code here still needed, as it is for the destination step? |
Done |
Hmm it might be this one @matbmapspeople |
Yes, still need that code ✅ @andreeaceachir142 |
Do you have any more comments @andreeaceachir142 on this merge request? |
Overview:
It was decided to remove last step from the directions (You have arrived). This steps is not something that Web SDK is serving.
Technical overview:
Working solution:
Screen.Recording.2025-02-06.at.12.53.49.mov