Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 2D/3D switch not respecting primaryColor prop #466

Merged
merged 3 commits into from
Feb 13, 2025
Merged

Fix 2D/3D switch not respecting primaryColor prop #466

merged 3 commits into from
Feb 13, 2025

Conversation

Lucaci-Andrei
Copy link
Contributor

What

  • Fix 2D/3D selector not respecting the primaryColor query parameter

How

  • Refactor mapOptions by moving the declaration up the dependency tree
  • Add a handle function that can be passed down to child components that can add additional values to mapOptions
  • Set up primary color prop in mapOptions

ammapspeople
ammapspeople approved these changes Feb 13, 2025
View reviewed changes
Copy link
Contributor

@ammapspeople ammapspeople left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@Lucaci-Andrei Lucaci-Andrei merged commit cc57755 into main Feb 13, 2025
@Lucaci-Andrei Lucaci-Andrei deleted the fix/view-mode-switch-primary-color-prop branch February 13, 2025 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ammapspeople ammapspeople ammapspeople approved these changes

@matbmapspeople matbmapspeople matbmapspeople approved these changes

Assignees
No one assigned
Labels
patch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Lucaci-Andrei @ammapspeople @matbmapspeople