-
Notifications
You must be signed in to change notification settings - Fork 334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue #755 - Revert to behavior from 7.4.0 and new features #758
Fix issue #755 - Revert to behavior from 7.4.0 and new features #758
Conversation
This completely emulates the logic of the Primitive adapter, which would be passed in 7.4.0 this case ( map IActivityBase -> IActivityBase). |
var targetExtention = sourceExt.Adapt<SampleInterfaceClsExtentions>(); | ||
|
||
|
||
var updExt = targetDerived.Adapt(targetExtention); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Base.Adapt(Derived) case
But this behavior is completely consistent with the access that the IActivityData interface itself provides - it does not have access to the Data property. If you add it, the state transfer will be carried out
Hm, It seems that in 7.4.0 only interfaces without content were processed in the primitive adapter. (IActivityBase in current sample). |
@DocSvartz Please synchronize your branch and I can do a review. I'll release the current code in development as pre02, and we can release this as pre03. Sounds good? |
@andrerav Ok |
Thank you @DocSvartz! |
New: