Skip to content

Commit

Permalink
Change default for network location fallback to off
Browse files Browse the repository at this point in the history
  • Loading branch information
simonpoole committed Nov 4, 2024
1 parent 8a3b6e5 commit fb16ee5
Show file tree
Hide file tree
Showing 7 changed files with 12 additions and 10 deletions.
2 changes: 1 addition & 1 deletion documentation/docs/help/en/Advanced preferences.md
Original file line number Diff line number Diff line change
Expand Up @@ -287,7 +287,7 @@ If GPS has been disabled by the user, don't ask to turn it on. Default: _off_.

### Fallback to network location

If the device is providing "Network" location data use it as a fallback if we haven't received a GPS location for a longer time. Default: _on_.
If the device is providing "Network" location data use it as a fallback if we haven't received a GPS location for a longer time. Default: _off_.

### Stale location after

Expand Down
10 changes: 6 additions & 4 deletions documentation/docs/tutorials/network_location.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,12 @@ If Vespucci detects that network positions can at least potentially be used, it

instead of the classic GPS icon on the screen and will alert you to which provider it is currently using via toasts (the short on-screen messages). The fallback to network locations can be disabled in the Location Settings in the Advanced Preferences.

Modern devices running a google variant of Android have three location mode setting (besides turning location services completely off):
~~Modern devices running a google variant of Android have three location mode setting (besides turning location services completely off):~~

* __Device only__ - use only the on device GPS location information, does not require sharing your location data with google
* __Battery saving__ - doesn't use GPS, instead uses mobile network, WLAN and other signals to determine your location, requires sharing of your location data with google
* __High accuracy__ - uses GPS and other signals to determine your location, requires sharing of your location data with google, this is typically only more "accurate" than __Device only__ if receiving GPS signals is seriously impaired
~~* __Device only__ - use only the on device GPS location information, does not require sharing your location data with google~~
~~* __Battery saving__ - doesn't use GPS, instead uses mobile network, WLAN and other signals to determine your location, requires sharing of your location data with google~~
~~* __High accuracy__ - uses GPS and other signals to determine your location, requires sharing of your location data with google, this is typically only more "accurate" than __Device only__ if receiving GPS signals is seriously impaired~~

As of Android 14 there seems to only be a _Google Location Accuracy_ setting in _Location services_ that changes if wifi is used or not.

Vespucci does not use the Google play servers "fused" location service and remains usable independent of if you are running it in a Google sanctioned environment or not.
2 changes: 1 addition & 1 deletion src/main/assets/help/en/Advanced preferences.html
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ <h3>Minimum GPS/GNSS-distance</h3>
<h3>Leave GPS/GNSS turned off</h3>
<p>If GPS has been disabled by the user, don't ask to turn it on. Default: <em>off</em>.</p>
<h3>Fallback to network location</h3>
<p>If the device is providing &quot;Network&quot; location data use it as a fallback if we haven't received a GPS location for a longer time. Default: <em>on</em>.</p>
<p>If the device is providing &quot;Network&quot; location data use it as a fallback if we haven't received a GPS location for a longer time. Default: <em>off</em>.</p>
<h3>Stale location after</h3>
<p>Time, in seconds, after which a location will be considered stale. Default: <em>60 s</em></p>
<h2>Server Settings</h2>
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/de/blau/android/prefs/Preferences.java
Original file line number Diff line number Diff line change
Expand Up @@ -270,7 +270,7 @@ public Preferences(@NonNull Context ctx) {
voiceCommandsEnabled = prefs.getBoolean(r.getString(R.string.config_voiceCommandsEnabled_key), false);

leaveGpsDisabled = prefs.getBoolean(r.getString(R.string.config_leaveGpsDisabled_key), false);
allowFallbackToNetworkLocation = prefs.getBoolean(r.getString(R.string.config_gps_network_key), true);
allowFallbackToNetworkLocation = prefs.getBoolean(r.getString(R.string.config_gps_network_key), false);

showIcons = prefs.getBoolean(r.getString(R.string.config_showIcons_key), true);

Expand Down
2 changes: 1 addition & 1 deletion src/main/res/xml-v24/advancedpreferences.xml
Original file line number Diff line number Diff line change
Expand Up @@ -541,7 +541,7 @@
android:summary="@string/config_leaveGpsDisabled_summary"
android:title="@string/config_leaveGpsDisabled_title" />
<androidx.preference.CheckBoxPreference
android:defaultValue="true"
android:defaultValue="false"
android:key="@string/config_gps_network_key"
android:summary="@string/config_gps_network_summary"
android:title="@string/config_gps_network_title" />
Expand Down
2 changes: 1 addition & 1 deletion src/main/res/xml-v29/advancedpreferences.xml
Original file line number Diff line number Diff line change
Expand Up @@ -541,7 +541,7 @@
android:summary="@string/config_leaveGpsDisabled_summary"
android:title="@string/config_leaveGpsDisabled_title" />
<androidx.preference.CheckBoxPreference
android:defaultValue="true"
android:defaultValue="false"
android:key="@string/config_gps_network_key"
android:summary="@string/config_gps_network_summary"
android:title="@string/config_gps_network_title" />
Expand Down
2 changes: 1 addition & 1 deletion src/main/res/xml/advancedpreferences.xml
Original file line number Diff line number Diff line change
Expand Up @@ -536,7 +536,7 @@
android:summary="@string/config_leaveGpsDisabled_summary"
android:title="@string/config_leaveGpsDisabled_title" />
<androidx.preference.CheckBoxPreference
android:defaultValue="true"
android:defaultValue="false"
android:key="@string/config_gps_network_key"
android:summary="@string/config_gps_network_summary"
android:title="@string/config_gps_network_title" />
Expand Down

0 comments on commit fb16ee5

Please sign in to comment.