Skip to content

Update shebang and error handling in entrypoint and healthcheck scripts #642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: next
Choose a base branch
from

Conversation

NamrathShetty
Copy link

This pull request includes changes to multiple versions of MariaDB's docker-entrypoint.sh and healthcheck.sh scripts to improve compatibility and error handling. The most important changes involve updating the shebang lines and modifying the set command options.

@grooverdan
Copy link
Member

shebang lines seem rather pointless as containers only have one defined environment where the full non-env path is correct.

On set - -Eu seems ok. I need more healthcheck.sh scripts for a greater confidence.

You may have seen, update.sh at top level will update per version files based on top level template file.

Please remove shebang changes, rebase to next and edit pr to target the next branch so some CI testing can be done on this.

@fauust
Copy link
Collaborator

fauust commented Mar 26, 2025

On set - -Eu seems ok. I need more healthcheck.sh scripts for a greater confidence.

I don't see any problem with -E, -u is a very good thing but it's quite impacting, please make sure every part of the script has been tested before merging...

@NamrathShetty NamrathShetty changed the base branch from master to next March 26, 2025 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants