Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup Codecov #2348

Merged
merged 4 commits into from
Aug 15, 2023
Merged

Setup Codecov #2348

merged 4 commits into from
Aug 15, 2023

Conversation

lesterong
Copy link
Contributor

@lesterong lesterong commented Jul 30, 2023

What is the purpose of this pull request?

  • Documentation update
  • Bug fix
  • Feature addition or enhancement
  • Code maintenance
  • DevOps
  • Improve developer experience
  • Others, please explain:

Overview of changes:

Generates coverage report from each package and uploads to Codecov using GitHub actions. Codecov report can be found here. Resolves #1755.

Anything you'd like to highlight/discuss:

  • In packages/cli, we don't run all the tests using Jest, looking into how to generate the coverage report for that properly

Testing instructions:

N.A.

Proposed commit message: (wrap lines at 72 characters)

Setup Codecov using GitHub actions


Checklist: ☑️

  • Updated the documentation for feature additions and enhancements
  • Added tests for bug fixes or features
  • Linked all related issues
  • No unrelated changes

@codecov
Copy link

codecov bot commented Jul 30, 2023

Codecov Report

❗ No coverage uploaded for pull request base (master@d6ad99d). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #2348   +/-   ##
=========================================
  Coverage          ?   44.82%           
=========================================
  Files             ?      122           
  Lines             ?     5133           
  Branches          ?     1082           
=========================================
  Hits              ?     2301           
  Misses            ?     2513           
  Partials          ?      319           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@tlylt
Copy link
Contributor

tlylt commented Aug 3, 2023

In packages/cli, we don't run all the tests using Jest, looking into how to generate the coverage report for that properly

Related to #771. @lesterong I think it's ok if we can't get those coverage stats for now, which should be easy to add when 771 is resolved.

.stylelintignore Show resolved Hide resolved
@tlylt
Copy link
Contributor

tlylt commented Aug 3, 2023

can we add the badge as well

@lesterong lesterong marked this pull request as ready for review August 14, 2023 16:44
README.md Outdated Show resolved Hide resolved
@tlylt tlylt added this to the v5.0.2 milestone Aug 14, 2023
@tlylt tlylt merged commit 9c5db5f into MarkBind:master Aug 15, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setup Code Coverage
2 participants