[pre-commit.ci] pre-commit autoupdate (#7336)

* [pre-commit.ci] pre-commit autoupdate updates: - [github.com/thibaudcolas/pre-commit-stylelint: v16.10.0 → v16.11.0](thibaudcolas/pre-commit-stylelint@v16.10.0...v16.11.0) - [github.com/rubocop/rubocop: v1.68.0 → v1.69.0](rubocop/rubocop@v1.68.0...v1.69.0) * Updated additional dependencies * Switched to https://github.com/rbubley/mirrors-prettier for the prettier pre-commit hook --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: David Liu <[email protected]>
MarkUsProject · Dec 11, 2024 · b241c74 · b241c74
1 parent 8e4cdcb
commit b241c74
Show file tree

Hide file tree

Showing 5 changed files with 13 additions and 14 deletions.
diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
@@ -16,20 +16,20 @@ repos:
               )$
         -   id: end-of-file-fixer
         -   id: trailing-whitespace
-  -   repo: https://github.com/pre-commit/mirrors-prettier
-      rev: v3.1.0
+  -   repo: https://github.com/rbubley/mirrors-prettier
+      rev: v3.4.2
       hooks:
         - id: prettier
           types_or: [javascript, jsx, css, scss, html]
   -   repo: https://github.com/thibaudcolas/pre-commit-stylelint
-      rev: v16.10.0
+      rev: v16.11.0
       hooks:
         - id: stylelint
           additional_dependencies: [
-              "stylelint@16.3.1",
+              "stylelint@16.11.0",
               "[email protected]",
-              "stylelint-config-sass-guidelines@11.1.0",
-              "[email protected].38",
+              "stylelint-config-sass-guidelines@12.1.0",
+              "[email protected].49",
             ]
           args: ["--fix"]
           types_or: ["css", "scss"]
@@ -39,7 +39,7 @@ repos:
               app/assets/stylesheets/common/_reset.scss
             )$
   - repo: https://github.com/rubocop/rubocop
-    rev: v1.68.0
+    rev: v1.69.1
     hooks:
       - id: rubocop
         args: ["--autocorrect"]
@@ -52,10 +52,10 @@ repos:
             Vagrantfile
           )$
         additional_dependencies:
-          - rubocop-rails:2.26.1
-          - rubocop-performance:1.22.1
+          - rubocop-rails:2.27.0
+          - rubocop-performance:1.23.0
           - rubocop-factory_bot:2.26.1
-          - rubocop-rspec:3.0.5
+          - rubocop-rspec:3.2.0
           - rubocop-rspec_rails:2.30.0
           - rubocop-capybara:2.21.0
 

diff --git a/app/assets/stylesheets/common/_mixins.scss b/app/assets/stylesheets/common/_mixins.scss
@@ -24,7 +24,7 @@ $breakpoints: (
       @content;
     }
   } @else {
-    @media ("#{$name}") {
+    @media ('#{$name}') {
       @content;
     }
   }

diff --git a/app/helpers/random_assign_helper.rb b/app/helpers/random_assign_helper.rb
@@ -12,7 +12,6 @@ module RandomAssignHelper
   # at the end of the assignment, including pre-existing peer reviews.
   def perform_random_assignment(pr_assignment, num_groups,
                                 reviewer_ids, reviewee_ids)
-
     # If the caller passes string ids from get_grouping_info,
     # they should be converted.
     reviewer_ids = reviewer_ids.map(&:to_i)

diff --git a/app/models/annotation_text.rb b/app/models/annotation_text.rb
@@ -30,7 +30,7 @@ class AnnotationText < ApplicationRecord
   validate :courses_should_match
 
   def should_have_deduction?
-    !self&.annotation_category&.flexible_criterion_id.nil?
+    !self.annotation_category&.flexible_criterion_id.nil?
   end
 
   def escape_content

diff --git a/app/models/flexible_criterion.rb b/app/models/flexible_criterion.rb
@@ -110,7 +110,7 @@ def weight
 
   def scale_marks
     super
-    return if self&.annotation_categories.nil?
+    return if self.annotation_categories.nil?
     annotation_categories = self.annotation_categories.includes(:annotation_texts)
     annotation_categories.each do |category|
       category.annotation_texts.each do |text|