Added conditional text color for partial marks in marks_panel.jsx #6483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @davidlin2k! I definitely see the motivation behind this PR. I'll need some time to think about what we want the UI to look like, and I'll keep you posted on this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This feature enables users to easily identify partial marks in an assignment and provides a better visual representation for users to interpret their feedback.
Your Changes
Description: Added an additional conditional red-text class for mark
Type of change (select all that apply):
Testing
It's a front-end change and does not affect existing functionalities. Tested through the web interface on A1.
Checklist