Skip to content

Commit

Permalink
remove usage of deprecated keywords
Browse files Browse the repository at this point in the history
  • Loading branch information
Noordsestern committed Feb 18, 2024
1 parent 89391b8 commit 132d895
Show file tree
Hide file tree
Showing 11 changed files with 31 additions and 31 deletions.
24 changes: 12 additions & 12 deletions tests/robot/Execution/test_start_process.robot
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ ${PROCESS_DEFINITION_KEY} demo_for_robot
*** Test Cases ***
Test starting process
# WHEN
${process_instance} start process ${PROCESS_DEFINITION_KEY}
${process_instance} Start Process Instance ${PROCESS_DEFINITION_KEY}

[Teardown] delete process instance ${process_instance}[id]

Expand All @@ -28,7 +28,7 @@ Test starting process with variables
${variables} Create Dictionary ${variable1_key}=${variable1_value}

# WHEN
start process ${PROCESS_DEFINITION_KEY} ${variables}
Start Process Instance ${PROCESS_DEFINITION_KEY} ${variables}

# AND
${first_workload} fetch workload topic=${existing_topic}
Expand All @@ -50,7 +50,7 @@ Test starting process with business key
${expected_business_key} Set Variable business 1

# WHEN
start process ${PROCESS_DEFINITION_KEY} business_key=${expected_business_key}
Start Process Instance ${PROCESS_DEFINITION_KEY} business_key=${expected_business_key}

# AND
${first_workload} fetch workload topic=${existing_topic} async_response_timeout=100
Expand All @@ -76,7 +76,7 @@ Test starting process with variables after activity
${after_activity_id} Set Variable Activity_process_element

# WHEN
start process ${PROCESS_DEFINITION_KEY} ${variables} after_activity_id=${after_activity_id}
Start Process Instance ${PROCESS_DEFINITION_KEY} ${variables} after_activity_id=${after_activity_id}

# AND
${first_workload} fetch workload topic=${existing_topic}
Expand All @@ -97,7 +97,7 @@ Test starting process with variables before activity
${before_activity_id} Set Variable Activity_process_element

# WHEN
start process ${PROCESS_DEFINITION_KEY} ${variables} before_activity_id=${before_activity_id}
Start Process Instance ${PROCESS_DEFINITION_KEY} ${variables} before_activity_id=${before_activity_id}

# AND
${first_workload} fetch workload topic=${existing_topic}
Expand All @@ -121,7 +121,7 @@ Test starting process with dict variables
${variables} Create Dictionary variables1=${variables1}

# WHEN
start process ${PROCESS_DEFINITION_KEY} ${variables}
Start Process Instance ${PROCESS_DEFINITION_KEY} ${variables}

# AND
${first_workload} fetch workload topic=${existing_topic}
Expand All @@ -143,7 +143,7 @@ Test starting process with file variables
${files} Create Dictionary my_file=tests/resources/rf-logo.png

# WHEN
start process ${PROCESS_DEFINITION_KEY} files=${files}
Start Process Instance ${PROCESS_DEFINITION_KEY} files=${files}

# AND
${first_workload} fetch workload topic=${existing_topic}
Expand All @@ -168,7 +168,7 @@ Test file content from starting process variable
${files} Create Dictionary my_file=${testfile}

# WHEN
start process ${PROCESS_DEFINITION_KEY} files=${files}
Start Process Instance ${PROCESS_DEFINITION_KEY} files=${files}

# AND
${first_workload} fetch workload topic=${existing_topic}
Expand All @@ -194,7 +194,7 @@ Test starting process with file variables
${files} Create Dictionary my_file=tests/resources/rf-logo.png

# WHEN
start process ${process_definition_key} files=${files}
Start Process Instance ${process_definition_key} files=${files}

# AND
${first_workload} fetch workload topic=${existing_topic}
Expand All @@ -220,7 +220,7 @@ Test file content from starting process variable
${files} Create Dictionary my_file=${testfile}

# WHEN
start process ${process_definition_key} files=${files}
Start Process Instance ${process_definition_key} files=${files}

# AND
${first_workload} fetch workload topic=${existing_topic}
Expand All @@ -246,7 +246,7 @@ Test starting process with file variables
${files} Create Dictionary my_file=tests/resources/rf-logo.png

# WHEN
start process ${process_definition_key} files=${files}
Start Process Instance ${process_definition_key} files=${files}

# AND
${first_workload} fetch workload topic=${existing_topic}
Expand All @@ -272,7 +272,7 @@ Test file content from starting process variable
${files} Create Dictionary my_file=${testfile}

# WHEN
start process ${process_definition_key} files=${files}
Start Process Instance ${process_definition_key} files=${files}

# AND
${first_workload} fetch workload topic=${existing_topic}
Expand Down
2 changes: 1 addition & 1 deletion tests/robot/ExternalTask/test_bpmn_error.robot
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ BPMN error without task does not fail
Test 'throw bpmn error' for existing topic
[Setup] set camunda url ${CAMUNDA_HOST}
# GIVEN
Start process ${PROCESS_DEFINITION_KEY}
Start Process Instance ${PROCESS_DEFINITION_KEY}
${variables} Create Dictionary text=Manna Manna

# AND
Expand Down
8 changes: 4 additions & 4 deletions tests/robot/ExternalTask/test_dict_vars_to_json.robot
Original file line number Diff line number Diff line change
Expand Up @@ -70,13 +70,13 @@ List variable is of type JSON in camunda
Process with dictionary variable
${my_dict} Create Dictionary a=1 b=2
${variables} Create Dictionary map=${my_dict}
${process_instance} start process ${PROCESS_DEFINITION_KEY} variables=${variables}
${process_instance} Start Process Instance ${PROCESS_DEFINITION_KEY} variables=${variables}
[Return] ${variables}

Process with list variable
${my_dict} Create list 1 2
${variables} Create Dictionary map=${my_dict}
${process_instance} start process ${PROCESS_DEFINITION_KEY} variables=${variables}
${process_instance} Start Process Instance ${PROCESS_DEFINITION_KEY} variables=${variables}
[Return] ${variables}

Workload is fetched
Expand All @@ -86,11 +86,11 @@ Workload is fetched
Process with dictionary variable is started
${my_dict} Create Dictionary a=1 b=2
${variables} Create Dictionary map=${my_dict}
${process_instance} start process ${PROCESS_DEFINITION_KEY} variables=${variables}
${process_instance} Start Process Instance ${PROCESS_DEFINITION_KEY} variables=${variables}
[Return] ${process_instance}

Process with list variable is started
${my_dict} Create Dictionary a=1 b=2
${variables} Create Dictionary map=${my_dict}
${process_instance} start process ${PROCESS_DEFINITION_KEY} variables=${variables}
${process_instance} Start Process Instance ${PROCESS_DEFINITION_KEY} variables=${variables}
[Return] ${process_instance}
4 changes: 2 additions & 2 deletions tests/robot/ExternalTask/test_fetch_and_lock.robot
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ ${EXISTING_TOPIC} process_demo_element
*** Test Cases ***
Test 'fetch and lock' for existing topic
#GIVEN
start process ${PROCESS_DEFINITION_KEY} ${{{'variable_1': 1}}}
Start Process Instance ${PROCESS_DEFINITION_KEY} ${{{'variable_1': 1}}}
#WHEN
${variables} fetch workload ${EXISTING_TOPIC}
#THEN
Expand All @@ -29,7 +29,7 @@ Test 'fetch and lock' with only specific variables
${input_variables} Create Dictionary
... ${variable_name1}=1
... ${variable_name2}=2
start process ${PROCESS_DEFINITION_KEY} ${input_variables}
Start Process Instance ${PROCESS_DEFINITION_KEY} ${input_variables}

#WHEN
${variables} fetch workload ${EXISTING_TOPIC} variables=${{['${variable_name1}']}}
Expand Down
12 changes: 6 additions & 6 deletions tests/robot/ExternalTask/test_get_amount_workloads.robot
Original file line number Diff line number Diff line change
Expand Up @@ -12,35 +12,35 @@ ${TOPIC_NAME} process_demo_element
There shall be as many tasks as started processes
[Documentation] https://github.com/MarketSquare/robotframework-camunda/issues/6
[Tags] issue-6
[Template] Start processes and check amount of workloads
[Template] Start Process Instancees and check amount of workloads
1
2
4

There shall be as many tasks as started processes
[Documentation] https://github.com/MarketSquare/robotframework-camunda/issues/6
[Tags] issue-6
[Template] Start process with business key and check for particular workload
[Template] Start Process Instance with business key and check for particular workload
1
2
4

*** Keywords ***
Start processes and check amount of workloads
Start Process Instancees and check amount of workloads
[Arguments] ${n}
Delete all instances from process '${PROCESS_DEFINITION_KEY}'
FOR ${i} IN RANGE 0 ${n}
start process ${PROCESS_DEFINITION_KEY}
Start Process Instance ${PROCESS_DEFINITION_KEY}
END

${amount_of_workloads} Get amount of workloads ${TOPIC_NAME}
Should be equal as integers ${amount_of_workloads} ${n}

Start process with business key and check for particular workload
Start Process Instance with business key and check for particular workload
[Arguments] ${n}
Delete all instances from process '${PROCESS_DEFINITION_KEY}'
FOR ${i} IN RANGE 0 ${n}
${last_process_instance} start process ${PROCESS_DEFINITION_KEY} business_key=${i}
${last_process_instance} Start Process Instance ${PROCESS_DEFINITION_KEY} business_key=${i}
END

${amount_of_workloads} Get amount of workloads ${TOPIC_NAME} process_instance_id=${last_process_instance}[id]
Expand Down
2 changes: 1 addition & 1 deletion tests/robot/ExternalTask/test_notify_failure.robot
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ Test 'Notify failure' with retries countdown

*** Keywords ***
A new process instance
Start process ${PROCESS_DEFINITION_KEY}
Start Process Instance ${PROCESS_DEFINITION_KEY}
${variables} Create Dictionary text=Manna Manna

process instance fetched
Expand Down
2 changes: 1 addition & 1 deletion tests/robot/Message/deliver_message.robot
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ Prepare Test Suite
Prepare testcase
Delete all instances from process '${PROCESS_DEFINITION_KEY_SEND_MESSAGE}'
Delete all instances from process '${PROCESS_DEFINITION_KEY_RECEIVE_MESSAGE}'
Start process ${PROCESS_DEFINITION_KEY_SEND_MESSAGE}
Start Process Instance ${PROCESS_DEFINITION_KEY_SEND_MESSAGE}


Get workload from topic '${topic}'
Expand Down
2 changes: 1 addition & 1 deletion tests/robot/ProcessInstance/test_delete_processes.robot
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ Get all instances
# Given
Upload process
${process_instances_before} get all active process instances ${PROCESS_NAME}
start process ${PROCESS_NAME}
Start Process Instance ${PROCESS_NAME}
${process_instances_after} get all active process instances ${PROCESS_NAME}

# EXPECT
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ Get Process Definitions

*** Keywords ***
Process Instance Is Present
${response} Start Process demo_for_robot
${response} Start Process Instance demo_for_robot
Set Global Variable ${PROCESS_INSTANCE_ID} ${response}[id]

Camunda Is Requested For Activity Instances Of The Process Instance
Expand Down
2 changes: 1 addition & 1 deletion tests/robot/ProcessInstance/test_get_all_instances.robot
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ Get all instances
${process_instances_before} get all active process instances ${PROCESS_NAME}

# WHEN
start process ${PROCESS_NAME}
Start Process Instance ${PROCESS_NAME}
${process_instances_after} get all active process instances ${PROCESS_NAME}

# THEN
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ A value

Process Instance Is Present
${variable} Create Dictionary foo=${value}
${response} Start Process demo_for_robot variables=${variable}
${response} Start Process Instance demo_for_robot variables=${variable}
Set Global Variable ${PROCESS_INSTANCE_ID} ${response}[id]

Camunda Is Requested For Variable Of The Process Instance
Expand Down

0 comments on commit 132d895

Please sign in to comment.