Switch to Static asserts to allow use of floats on DUAL_X_CARRIAGE configurations #27701
+6
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… & include test to insure X2 cannot hit X1 in the parked position.
|
CI tests failing in setup E: Failed to fetch mirror+file:/etc/apt/apt-mirrors.txt/pool/main/libs/libsndfile/libsndfile1_1.0.31-2ubuntu0.1_amd64.deb 404 Not Found [IP: 52.147.219.192 80] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This will allow Floats to be used for X2_MAX_POS, X2_HOME_POS, X1_MIN_POS & X1_MAX_POS on DUAL_X_CARRIAGE configurations.
I also removed a redundant check on the X2_MAX_POS and replaced with a check to avoid the X2 hitting X1 while X1 is parked.
Requirements
Tested using the configuration from the below Issue
Benefits
Allows for using Floats when using DUAL_X_CARRIAGE
Configurations
configuration.zip
Related Issues
(#27623)