Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better DPK support #291

Closed
wants to merge 37 commits into from
Closed
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
37 commits
Select commit Hold shift + click to select a range
f12457d
Implement `verifyDevicePubKey`
agektmr Aug 16, 2022
54b2629
Working `verifyDevicePublicKey`.
agektmr Aug 17, 2022
9506187
Update DPK impl.
agektmr Aug 18, 2022
f124eca
Bump the version to 6.0.0
agektmr Aug 18, 2022
82b74ff
Add temporary attestation verification
agektmr Aug 18, 2022
f83709c
Update DPK logic
agektmr Aug 18, 2022
1c072b4
DPK update
agektmr Aug 19, 2022
6dc3e80
Update DPK verifications
agektmr Aug 20, 2022
8e8cfb4
Reorganize the interface
agektmr Aug 21, 2022
9250cd5
Update packages/server/src/extensions/devicePublicKey/verifyDpkSignat…
agektmr Aug 22, 2022
9c21bea
Update packages/server/src/extensions/devicePublicKey/verifyDpkSignat…
agektmr Aug 22, 2022
5edeb63
Update packages/server/src/extensions/devicePublicKey/verifyDpkSignat…
agektmr Aug 22, 2022
9694a80
Update DPK
agektmr Aug 22, 2022
9f0ea58
Update DPK logic
agektmr Aug 26, 2022
d5745b6
Attestation binary equality check
agektmr Aug 26, 2022
000c9b4
Add comment
agektmr Aug 26, 2022
76153ff
Return device public key to RP
agektmr Aug 26, 2022
2228dd3
Successful test cases added
agektmr Aug 27, 2022
ac5413e
Reflect feedback
agektmr Aug 29, 2022
a20cade
chore(release): publish v6.3.0-alpha.0
MasterKale Sep 29, 2022
4ca4a97
Align DPK registration with DPK authentication
agektmr Sep 2, 2022
bf719c4
Some progress aligning with the latest DPK spec
agektmr Sep 6, 2022
501b6c3
All tests succeed now
agektmr Sep 9, 2022
41ba0e6
Better test coverage
agektmr Sep 10, 2022
0747463
Reflect feedback
agektmr Sep 20, 2022
f6a99a2
Remove package.json files
agektmr Sep 20, 2022
e188128
Parse dpk result on the browser
agektmr Oct 2, 2022
3fad254
Update packages/browser/src/helpers/parseClientExtensionResults.ts
agektmr Oct 5, 2022
72f5f64
Revert package-lock.json
agektmr Oct 5, 2022
edca70e
Update packages/server/src/authentication/verifyAuthenticationRespons…
agektmr Oct 5, 2022
efe0c41
Reflect feedback
agektmr Oct 5, 2022
cacb165
Reflect feedback
agektmr Oct 6, 2022
883b49d
chore(release): publish v6.3.0-alpha.1
MasterKale Oct 6, 2022
de678e7
Encode DPK output for simplicity
agektmr Oct 13, 2022
8d3602f
Update AuthenticationExtensionsClientInputs
agektmr Oct 13, 2022
4ce11e7
DPK related changes:
agektmr Nov 21, 2022
c20bde9
Allow extending DPK object
agektmr Nov 23, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Reflect feedback
  • Loading branch information
agektmr committed Jan 21, 2023
commit cacb1657e06e35d435fe3f77ce5d77aa86d76d90
2 changes: 1 addition & 1 deletion packages/browser/src/methods/startAuthentication.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -296,7 +296,7 @@ test('should return authenticatorAttachment if present', async () => {
return new Promise(resolve => {
resolve({
response: {},
getClientExtensionResults: () => {},
getClientExtensionResults: () => ({}),
authenticatorAttachment: 'cross-platform',
});
});
Expand Down
2 changes: 1 addition & 1 deletion packages/browser/src/methods/startRegistration.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -232,7 +232,7 @@ test('should return authenticatorAttachment if present', async () => {
return new Promise(resolve => {
resolve({
response: {},
getClientExtensionResults: () => {},
getClientExtensionResults: () => ({}),
authenticatorAttachment: 'cross-platform',
});
});
Expand Down