Adding new function to move sliders from the outside #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 This works where the current master branch of turban's appears not to, for me. Thanks go to both of you, for working on this! |
|
FYI: the example website didn't work for me on Chrome. |
|
@Seanny123: I've re-checked the website and it seems to be working fine under an up-to-date Chrome (as of today). |
|
Maybe it's Ubuntu's fault? I'll try it later on Windows and I'll get back to you. Firefox works though. (: |
|
Just tried on an up-to-date Chrome under Ubuntu 14.04 and works OK. |
|
Oh jeez. It was one of my add-ons. I forgot to test opening the link in an incognito window. This is really embarrassing. Sorry about that. |
|
No problem! Thanks for the feedback, anyway :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've just used d3.slider in an application to aid my students on an assignment. Since I was in the need of a way to make the slider move from the outside (that is, clicking buttons or pressing some keys), I decided to take a look at the code and hack it a little bit.
An example: http://lukius.github.io/d3.slider/
By the way, great job! Thanks!