Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom scale support and sizing based on rendered container width #38

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

megankanne
Copy link

  • Enables completely custom scales (eg. a polylinear scale) by only setting scale range if scale is not provided by user.
  • Removes use of two scales ("scale" to map input value to slider width percentage and "axisScale" to map input value to slider pixel position). Replaces them with single scale mapping input value to slider pixel position and a function to translate that slider pixel position to a percentage of slider length.
  • Removes requirement that container div has a css width style explicitly set. Instead, uses getBoundingClientRect() to determine the rendered width of the div.
  • Adds automatic axis label wrapping using Mike's function from http://bl.ocks.org/mbostock/7555321

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant