-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SMILES data type #436
Open
merkys
wants to merge
15
commits into
Materials-Consortia:develop
Choose a base branch
from
merkys:SMILES-data-type
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
SMILES data type #436
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
9ec5181
Describe SMILES data type.
merkys 775fda0
Add SMILES property as is done in #392, but using SMILES data type.
merkys 06409e0
Describe comparisons involving SMILES.
merkys 9d94f74
Merge branch 'develop' into SMILES-data-type
merkys 59af3fa
Decouple SMILES from other data types in the enumeration of operator …
merkys 08997e3
Update optimade.rst
merkys bcc69c1
Update optimade.rst
merkys e938254
Merge branch 'develop' into SMILES-data-type
merkys c96cab1
Merge branch 'develop' into SMILES-data-type
merkys 57b6ca8
Removing sentences mentioning SMILES canonicalization as they do not …
merkys b7c002b
Merge branch 'SMILES-data-type' of github.com:merkys/OPTIMADE into SM…
merkys 8fb816c
Define `x-optimade-type` for smiles as #457 is merged now.
merkys 7444d6e
Merge branch 'develop' of github.com:Materials-Consortia/OPTIMADE int…
merkys 9621645
Merge branch 'develop' into SMILES-data-type
merkys afb319b
Update optimade.rst
merkys File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To me, this line is not entirely clear. Does this mean that we support querying for chemical groups ? As would be defined with SMARTS query language ? In that case we should probably mention the SMARTS query language.
Or do we only support searching for whole molecules in the SMILES string which could be separated by a "."?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed, this deserves some clarification. I would not introduce SMARTS yet, but it is worth explaining what
smiles CONTAINS "c1ccccc1"
means.When I was putting this PR together, I was thinking about substructure search. That is,
"c1ccccc1"
would as well be found in fluorobenzene. But we may limit ourselves to complete match of whole molecular entities (i.e., parts of SMILES separated by.
). Which use would have better cost/benefit ratio?