Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ranged properties #452
Add ranged properties #452
Changes from 22 commits
c18cf0c
7dc50f2
6afcf9c
1a55c2a
b597a67
37db878
a832751
16aba07
b1d69a8
edbfc25
14de45d
906db81
1feb4a9
a96dffe
15f599c
73905dc
c6834f3
b0cc94c
0cee1e6
d7c8a9c
d1e8d74
139c70e
916d6f2
ee3651e
1f794b6
169a1f4
f513596
65b8ad1
94db38c
033ea11
3762d30
8332567
a87b301
7e9b4f4
4b298c5
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should
range_id
really be a per-entry metadata? Is that perhaps something we define as part of the property definition?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have not yet been able to come up with an example where defining
range_id
in the property definition would cause more problems than at the single entry level. So I think it should be possible to define it in the property definition.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.