Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove macos-12 from ci #332

Merged

Conversation

drbergman
Copy link
Collaborator

@drbergman drbergman commented Nov 15, 2024

gh actions deprecation upcoming
still have macos-14 ci

Copy link
Collaborator

@vincent-noel vincent-noel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes, I forgot about this. We are getting close. Thanks for the reminder :)

We shouldn't just remove it, because 12 and 13 are still x86_64 (non arm64 or M1) chips, and we should test on these as long as we can. So best would be to just change every macos-12 to macos-13, and pray that it works.

Same thing for the build_binaries script, which is building the universal (x86 and arm86) binaries for mac, for this we still need a x86_64 environment.

If you have time to do this, also for the build_binaries.yml, that's awesome, otherwise I can do it hopefully next week !

@drbergman
Copy link
Collaborator Author

done! now we just hold our breath for the tests...

gh actions deprecation upcoming
silence gcc@13 warnings in build binaries
@drbergman drbergman force-pushed the remove-macos-12-from-ci branch from 0b1ff2c to d02de52 Compare November 15, 2024 21:45
@drbergman
Copy link
Collaborator Author

drbergman commented Nov 21, 2024

oops...just realized I updated this branch to merge with the rc1 test branch...that means that we cannot merge this PR unless we like all the PRs combined in 1.14.1-rc1 branch. I think we will, but noting it here just in case

undid this and now (the force-push next on this timeline) it's regained its independence from the 1.14.1-rc1 branch

@drbergman drbergman force-pushed the remove-macos-12-from-ci branch from 8f6ded5 to d02de52 Compare December 6, 2024 01:45
@MathCancer MathCancer merged commit eb5e925 into MathCancer:development Dec 12, 2024
208 checks passed
@drbergman drbergman deleted the remove-macos-12-from-ci branch December 12, 2024 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants