-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR into master from dev/olga/add-applyMathpixMarkdownPlugins #350
base: master
Are you sure you want to change the base?
Conversation
I'm okay with the implementation. But user-facing documentation may be added to readme. |
Sure, I'll do it. |
Can you add type |
Done. |
|
||
export const applyMathpixMarkdownPlugins = (options: TMarkdownItOptions = {}): MarkdownIt => { | ||
let md: MarkdownIt = mdInit(options); | ||
md = injectRenderRules(md); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe it could better to change injectRenderRules
to infer the type for MarkdownIt
injectRenderRules = (renderer: MarkdownIt) => {
I still have problem for inferring the types for markdown-it. |
branch:
dev/olga/add-applyMathpixMarkdownPlugins
applyMathpixMarkdownPlugins
applyMathpixMarkdownPlugins
renderedHtml: